On Thu, May 9, 2019 at 12:02 PM Craig Russell <apache....@gmail.com> wrote: > > Hi Sebb, > > Thanks for taking care of this important issue. > > Is there any takeaway to avoid this in future? It has happened a small number > of times in the past, and it would be good to know if you think it's solved > for now or solved until the next time.
Sebb isolated the problem to a recent change I made to a dependency, namely ruby2js. Ruby has a method named merge than older versions of JavaScript didn't have a good equivalent, but newer versions do. When I added support for that method, it broke a class in the secretary workbench that had defined a method named merge. I fixed ruby2js to give priority to locally defined methods over language builtins, and added a test case. - Sam Ruby > Thanks, > > Craig > > > On May 9, 2019, at 4:05 AM, sebb <seb...@gmail.com> wrote: > > > > On Thu, 9 May 2019 at 11:03, sebb <seb...@gmail.com > > <mailto:seb...@gmail.com>> wrote: > >> > >> On Thu, 9 May 2019 at 10:05, sebb <seb...@gmail.com> wrote: > >>> > >>> On Thu, 9 May 2019 at 04:48, Craig Russell <apache....@gmail.com> wrote: > >>>> > >>>> I am seeing three documents sent to secretary that have not appeared in > >>>> the secretary workbench. > >>> > >>> Investigating ... > >>> > >>> I think I have found the messages to which you refer: > >>> > >>>> All times PDT (GMT -7) > >>>> Tuesday 8:54 PM > >>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cCAKpzXcZ4OUUdg3y+dS1snfGXhP=qddams_efojjkwr4sgz0...@mail.gmail.com%3e > >>> > >>> Message-ID: > >>> <CAKpzXcZ4OUUdg3y+dS1snfGXhP=qddams_efojjkwr4sgz0...@mail.gmail.com> > >>> > >>>> Wednesday 12:05 AM > >>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3c87daa111-31e1-410a-8add-a5812ad9fc90@Spark%3e > >>> > >>> Message-ID: <87daa111-31e1-410a-8add-a5812ad9fc90@Spark> > >>> > >>>> Wednesday 12:23 PM > >>> https://mail-search.apache.org/members/private-arch/officers-secretary/201905.mbox/%3cca+aakm_4z+4nj-wbixnz4o9avisszn-2nvk4kuhuqayuxfs...@mail.gmail.com%3e > >>> > >>> Message-ID: > >>> <ca+aakm_4z+4nj-wbixnz4o9avisszn-2nvk4kuhuqayuxfs...@mail.gmail.com> > >>> > >>>> > >>>> The whimsy user interface seems to be ok. Any ideas what happened to > >>>> these three ICLAs? > >>> > >>> About to look on Whimsy > >> > >> When I tried loading the 201905.yml file on my local system, all the > >> messages showed up (as well as some others). > >> > >> The messages all appear in the JSON file, which is what drives the display: > >> > >> https://whimsy.apache.org/secretary/workbench/201905 > >> > >> I don't yet know why the live site thinks there are no messages left > >> to process, whereas my local copy displays several entries. > >> > >> The JSON is the same on my system, so it looks to be an issue with the > >> Javascript. > >> I will add some console logging to try and trace what is happening. > > > > It seems that the live installation generates different Javascript > > from my local version. > > In particular, it handles self.merge differently; not entirely sure > > what the code is trying to do. > > I renamed the method and it all seems to be working now. > > > > I think my system uses ruby2js 3.0.7 whereas whimsy-vm4 uses 3.1.0; I > > assume that may be the cause. > > > >>>> Thanks, > >>>> > >>>> Craig > >>>> > >>>> Craig L Russell > >>>> c...@apache.org <mailto:c...@apache.org> > Craig L Russell > c...@apache.org >
