Dunno whether this is finalized yet, but the format of availids is not correctly represented by the regex. I made a comment on PR#84 but don't know the current status.
This assumes that the availid is alphanumeric characters from one to unbounded followed by a space or many spaces. But availids (historical) might contain special characters "." or "_" and numbers. Should the regex be changed from [a-z]+ to [a-z._0-9]+ to accommodate the dozens of availids that contain special characters? So is this PR still open? Thanks, Craig > On Feb 26, 2020, at 7:14 AM, Craig L Russell <notificati...@github.com> wrote: > > Hi Rich, > > The file format was changed last year to include the availid of the nominated > members so there was an unambiguous record. There are several cases of > committers with the same name that are distinguished by their non-public > name. They each have a unique availid. > > HTH, > Craig > > > On Feb 25, 2020, at 12:39 PM, Rich Bowen <notificati...@github.com> wrote: > > > > Fixes regex to match the new format of the nominated-members.txt file. > > Specifically, since we now have "availaid FNAME LNAME:" we need to discard > > the availid to match the email subject line, and (maybe?) the ":" from the > > end of the line. > > > > Again ... why did we change the file format? > > > > You can view, comment on, or merge this pull request online at: > > > > https://github.com/apache/whimsy/pull/84 > > <https://github.com/apache/whimsy/pull/84> > > Commit Summary > > > > Update to recognize the new format of the nominated-members.txt file > > Fix regex > > Fix regex > > File Changes > > > > M www/members/nominations.cgi > > <https://github.com/apache/whimsy/pull/84/files#diff-0> (2) > > Patch Links: > > > > https://github.com/apache/whimsy/pull/84.patch > > <https://github.com/apache/whimsy/pull/84.patch> > > https://github.com/apache/whimsy/pull/84.diff > > <https://github.com/apache/whimsy/pull/84.diff> > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > <https://github.com/apache/whimsy/pull/84?email_source=notifications&email_token=AD4M6RFVCU2LWLWGVVNGU6LREV6XDA5CNFSM4K3RXNA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQF7XKQ>, > > or unsubscribe > > <https://github.com/notifications/unsubscribe-auth/AD4M6REX3NFPWAFI33HLJ5DREV6XDANCNFSM4K3RXNAQ>. > > > > Craig L Russell > c...@apache.org > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/whimsy/pull/84?email_source=notifications&email_token=AAS2LJVOPNNV6ONNMVPEUV3RE2BNFA5CNFSM4K3RXNA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENATUGA#issuecomment-591477272>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAS2LJVLP5EIJHD5RC7ZMNDRE2BNFANCNFSM4K3RXNAQ>. > Craig L Russell javadog....@gmail.com 1220 University Ave San Jose, CA 95126
