On Mon, May 25, 2020 at 8:26 AM sebb AT ASF <s...@apache.org> wrote: > > > - unless icla.id == 'notinaval' > > + unless icla.id == 'notinavail' > > To avoid this happening again, maybe we should be using constants for > 'magic' strings. > Easy enough to implement as a constant local to this file, but in this > case, the constant has much wider applicability. > > Would lib/asf.rb be a suitable place for such constants, or would it > be better to have a Constants class?
Being pedantic, those are orthogonal choices. You can have a Constants class inside of lib/asf.rb, or you can add constants to the ASF module in a separate file. That being said, the option I personally prefer is the one you seem to have settled on: a noid? method. - Sam Ruby
