On Thu, 11 Jun 2020 at 22:17, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Thu, Jun 11, 2020 at 5:08 PM sebb <seb...@gmail.com> wrote:
> >
> > On Thu, 11 Jun 2020 at 21:53, Sam Ruby <ru...@intertwingly.net> wrote:
> > >
> > > On Thu, Jun 11, 2020 at 4:46 PM sebb <seb...@gmail.com> wrote:
> > > >
> > > > On Thu, 11 Jun 2020 at 19:36, Sam Ruby <ru...@intertwingly.net> wrote:
> > > > >
> > > > > On Thu, Jun 11, 2020 at 2:19 PM sebb <seb...@gmail.com> wrote:
> > > > > >
> > > > > > I get the following error when running the tests locally:
> > > > > >
> > > > > > $ rspec www/board/agenda/
> > > > > > Error: Cannot find module 'jsdom-global/register'
> > > > >
> > > > > What happens if you run the following instead?
> > > > >
> > > > > $ bundle exec rake test
> > > >
> > > > $ bundle exec rake test
> > > > bundler: failed to load command: rake
> > > > (/usr/local/lib/ruby/gems/2.6.0/bin/rake)
> > > > Gem::Exception: can't find executable rake for gem rake. rake is not
> > > > currently included in the bundle, perhaps you meant to add it to your
> > > > Gemfile?
> > > >
> > > > /usr/local/Cellar/ruby/2.6.5/lib/ruby/2.6.0/bundler/rubygems_integration.rb:462:in
> > > > `block in replace_bin_path'
> > > >
> > > > /usr/local/Cellar/ruby/2.6.5/lib/ruby/2.6.0/bundler/rubygems_integration.rb:482:in
> > > > `block in replace_bin_path'
> > > > /usr/local/lib/ruby/gems/2.6.0/bin/rake:23:in `<top (required)>'
> > >
> > > Were you running this in the board/agenda directory?
> >
> > No.
> >
> > Just tried, and I get:
> >
> > Error: Cannot find module 'jsdom-global/register'
> >
> > If I comment out the line in vue_server.rb:
> > 74: cleanup = require("jsdom-global/register")
> >
> > I then get
> >
> > Error: Cannot find module 'vue'
> >
> > There's clearly something missing from my installation, but I'm not sure
> > what.
>
> What you are missing:
>
> rubys@sams-mbp:~/git/whimsy/www/board/agenda$ ls
> node_modules/jsdom-global/register.js
> node_modules/jsdom-global/register.js
>
> The way you get this is via 'npm install'. npm install is run
> automatically by the test if package-lock.json is not present.
>
> I'm guessing that you have a package-lock.json file but don't have a
> node_modules/jsdon-global directory. The easiest way to ensure that
> you are running in a clean environment is to run:
>
> bundle exec rake clobber
Thanks, that has fixed the problems.
> ... as described below:
>
> > > > > This shouldn't be necessary, but should you at a later point get to
> > > > > where you need to cleanup after a failed test, run the following
> > > > > command:
> > > > >
> > > > > $ bundle exec rake clobber
> > > >
> > > > The same error message ...
>
> Try again, but this time, from the board/agenda directory.
>
> > > > > > The tests work OK in Travis, so I assume there must be something
> > > > > > missing from my installation, but I don't know what.
> > > > >
> > > > > The tests aren't failing, but do show some svn error messages.
> > > > >
> > > > > Note: the tests that are listed as pending were recently disabled.
> > > > > Those tests depend on the content of the templates, which were
> > > > > recently moved out of the Whimsy github repository and moved to the
> > > > > foundation/board/templates directory in svn.
> > > > >
> > > > > > It would be useful to fix this so I can check changes before
> > > > > > committing in future...
> > > > >
> > > > > Indeed!
> > > > >
> > > > > > Sebb
> > > > >
> > > > > - Sam Ruby
>
> - Sam Ruby
