rbowen opened a new pull request, #305: URL: https://github.com/apache/whimsy/pull/305
Problem: The privacy policy site check flags 17 projects as non-compliant even though they link to valid privacy policy pages hosted on their own *.apache.org subdomain. This is a 89% false positive rate for this check. Fix: Expand the CHECK_VALIDATE regex to also accept any URL on *.apache.org that contains "privac" in the path. Projects that will move from WARN → PASS: beam, bookkeeper, bval, helix, hudi, johnzon, karaf, knox, openjpa, opennlp, pig, shiro, systemds, tomee, uima, unomi, zookeeper Still correctly rejected: policies.google.com/privacy (parquet), github.com/apache/privacy-website (dataprivacy) Many projects host their own privacy policy page on their *.apache.org subdomain (e.g., beam.apache.org/privacy_policy, karaf.apache.org/privacy.html). These pages typically mirror or link to the canonical ASF privacy policy, but are currently flagged as non-compliant because the validation regex only accepts two exact canonical URLs. This change adds a third alternative that accepts any *.apache.org URL containing 'privac' (covering privacy, privacy-policy, privacypolicy, etc.). This eliminates 17 of 19 privacy warnings as false positives while still correctly rejecting links to non-ASF domains (e.g., policies.google.com). Also adds rspec tests for the privacy check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
