andrewmusselman commented on code in PR #318:
URL: https://github.com/apache/whimsy/pull/318#discussion_r3510439287
##########
lib/whimsy/sitewebsite.rb:
##########
@@ -206,6 +210,17 @@ def display_overview(sites, analysis, checks, tlp = true)
cls = SiteStandards.label(analysis, links, c, n)
_td '', class: cls, data_sort_value: sort_order[cls]
end
+ downloads = links['downloads'] || {}
+ if downloads.empty?
Review Comment:
Okay, for PMCs that don't make releases and other websites like Brand
Management, Data Privacy, Diversity, (what else?) we add another color/legend
to:
```
* Sites with links to primary ASF page
* Sites with link, but not an expected ASF one
* Sites with no link for this topic
```
E.g., "Sites with no link for this topic, and not expected to"
And hard code it or find that data?
I am red/green colorblind so please tell me what you would like in hex code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
