[
https://issues.apache.org/jira/browse/WHIRR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124559#comment-13124559
]
Tom White commented on WHIRR-325:
---------------------------------
+1 looks good.
I agree with Paul that sleep times should be tunable in general, but in this
case it's a local process (i.e. not calling out to other instances) and it only
serves to suppress an error message as far as I can tell. So it's worth adding
until it's fixed in jclouds, since the message is misleading for users, but I'm
not sure if it needs to be tunable in this case.
> Reduce cloud provider-specific code in scripts
> ----------------------------------------------
>
> Key: WHIRR-325
> URL: https://issues.apache.org/jira/browse/WHIRR-325
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Andrei Savu
> Attachments: WHIRR-325-rewrite-run-script.patch, WHIRR-325.patch,
> WHIRR-325.patch, WHIRR-325.patch, WHIRR-325.patch
>
>
> Many of the bash functions have a cloud provider option (-c) that they use to
> determine how to find the local public/private IP address, or the local data
> directory (/mnt vs /data, for example).
> We should pass what is needed (e.g. IP addresses, directories), or at least
> put the code in a common function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
