[ 
https://issues.apache.org/jira/browse/WHIRR-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136896#comment-13136896
 ] 

Andrei Savu edited comment on WHIRR-273 at 10/27/11 8:31 AM:
-------------------------------------------------------------

Nice work! I'm glad to see this working. 

Here are some things I've noticed while looking at the patch:

* remove the zookeeper tarball url from the riak byon recipe 
* let the user specify the version for the install artefacts (e.g. 
whirr.riak.version=0.1.0) - I assume the naming convention is consistent for 
all releases
* do not make the config files (app.config, vm.args) writable by all users 
(chomod 777)
* extract the retry loop from install_riak() as a function to reduce code 
duplication

I will now start a cluster and get back with more feedback about integration 
testing. 

                
      was (Author: savu.andrei):
    Nice work! I'm glad to see this working. 

Here are some things I've noticed while looking at the patch:

* remove the zookeeper tarball url from the riak byon recipe (e.g. 
whirr.riak.version=0.1.0) - I assume the naming convention is consistent for 
all releases
* let the user specify the version for the install artefacts
* do not make the config files (app.config, vm.args) writable by all users 
(chomod 777)
* extract the retry loop from install_riak() as a function to reduce code 
duplication

I will now start a cluster and get back with more feedback about integration 
testing. 

                  
> Add Riak as a service
> ---------------------
>
>                 Key: WHIRR-273
>                 URL: https://issues.apache.org/jira/browse/WHIRR-273
>             Project: Whirr
>          Issue Type: New Feature
>          Components: new service
>            Reporter: Andrei Savu
>            Assignee: Jhey Tompkins
>         Attachments: WHIRR-273-Add-Riak-as-a-Service.patch, 
> WHIRR-273-Add-Riak-as-a-Service.patch, WHIRR-273-Add-Riak-as-a-Service.patch, 
> WHIRR-273-Add-Riak-as-a-Service.patch
>
>
> "Riak is a Dynamo-inspired database that is being used in production by 
> companies like Mozilla and Comcast. Riak scales predictably and easily and 
> simplifies development by giving users the ability to quickly prototype, 
> test, and deploy their applications.
> A truly fault-tolerant system, Riak has no single point of failure. No 
> machines are special or central in Riak, so developers and operations 
> professionals can decide exactly how fault-tolerant they want and need their 
> applications to be."
> -- http://wiki.basho.com/Home.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to