[
https://issues.apache.org/jira/browse/WHIRR-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149454#comment-13149454
]
Tom White commented on WHIRR-429:
---------------------------------
Thanks for the contribution, Jean-Baptiste. Looks good, here are a few comments
on the patch:
* Can you add an integration test for the service? Something simple to check
that the service is running is usually fine - have a look at one of the other
services like ZooKeeper for an example.
* It would be good to add a recipe file so folks can use the service easily.
* Indentation should be 2 spaces.
> Add Karaf service
> -----------------
>
> Key: WHIRR-429
> URL: https://issues.apache.org/jira/browse/WHIRR-429
> Project: Whirr
> Issue Type: New Feature
> Components: new service
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: 0.7.0
>
> Attachments: WHIRR-429.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
