Hi
I doubt that its because of build-tools not having a parent since the
assembly is not even executed from build tools, my guess is that is has
something to do with scopes.
In any case I think I found something that works.
If all the deps required are the client's and the client is outputting
them on the build anyway why not use those?
Please try out the following assembly desc:
<assembly
xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.0
http://maven.apache.org/xsd/assembly-1.1.0.xsd";>
<id>bin</id>
<formats>
<format>tar.gz</format>
</formats>
<fileSets>
<fileSet>
<directory>cli/target/lib/</directory>
<outputDirectory>lib</outputDirectory>
<useDefaultExcludes>true</useDefaultExcludes>
<includes>
<include>**</include>
</includes>
</fileSet>
<fileSet>
<directory>${project.basedir}</directory>
<useDefaultExcludes>true</useDefaultExcludes>
<excludes>
<exclude>NOTICE-src.txt</exclude>
<exclude>**/.project</exclude>
<exclude>**/.gitignore</exclude>
<exclude>**/${project.build.directory}/**</exclude>
<exclude>**/dependency-reduced-pom.xml</exclude>
<exclude>**/*.log</exclude>
<exclude>**/*.log.*</exclude>
<exclude>**/*.rej</exclude>
<exclude>**/*.classpath</exclude>
<exclude>**/whirr-logo.ai</exclude>
<exclude>services/voldemort/lib/*.jar</exclude>
<exclude>.idea/**</exclude>
<exclude>**/*.iml</exclude>
<exclude>**/*.ipr</exclude>
<exclude>**/*.iws</exclude>
</excludes>
</fileSet>
<fileSet>
<directory>${project.build.directory}/site</directory>
<outputDirectory>docs</outputDirectory>
</fileSet>
</fileSets>
</assembly>
On Dec 14, 2011, at 1:52 PM, Andrei Savu wrote:
> I have done all that. My guess is that this is happening because
> build-tools no longer have a parent project.
>
> On Wed, Dec 14, 2011 at 9:50 PM, Adrian Cole <[email protected]> wrote:
>
>> shotgunning related info you probably already know/are using:
>>
>> the assembly is configured here:
>> build-tools/src/assemble-bin.xml
>>
>> build instructions [1] say:
>> mvn site
>> mvn package assembly:assembly
>>
>> we should have already done mvn clean install before package to ensure
>> updates to dependencies are visible.
>>
>> hope it helps
>> -A
>>
>> [1] https://cwiki.apache.org/WHIRR/how-to-release.html
>> On Wed, Dec 14, 2011 at 11:29 AM, Alex Heneveld
>> <[email protected]> wrote:
>>> No joy. Tried several things but still neither slf4j-log4j nor log4j
>> show
>>> up in the assembly tar.gz. Any other ideas?
>>>
>>> Best
>>> Alex
>>>
>>> ----- Reply message -----
>>> From: "Adrian Cole" <[email protected]>
>>> Date: Wed, Dec 14, 2011 16:59
>>> Subject: [VOTE] Release Whirr version 0.7.0 - logging
>>> To: "[email protected]" <[email protected]>
>>>
>>> +1 in the case of the cli, choosing a specific slf4j impl makes sense,
>>> and it should be consistent between test and runtime
>>>
>>> On Wed, Dec 14, 2011 at 8:46 AM, Alex Heneveld
>>> <[email protected]> wrote:
>>>>
>>>> Andrei-
>>>>
>>>> I'm thinking we need to add <scope>runtime</scope> to the slf4j-log4j12
>>>> dependency in cli/pom.xml. Am testing it now.
>>>>
>>>> My reasoning: most of the poms rightly give <scope>test</scope> to that
>>>> logging-implementation dependency. However cli (and example) give it
>> the
>>>> default scope which is "compile" which works fine until we combine it.
>> In
>>>> the presence of multiple scopes, "test" seems to trump "compile"
>>>> (surprisingly to me). "runtime" however trumps both. This according to
>>>> [1].
>>>>
>>>> Best
>>>> Alex
>>>>
>>>> [1]
>>>>
>>>>
>> http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope
>>>>
>>>>
>>>> On 13/12/2011 20:42, Andrei Savu wrote:
>>>>>
>>>>> Unfortunately I am not happy with the binary release. Is anyone else
>>>>> having
>>>>> CLI logging issues?
>>>>> It should be something easy to fix.
>>>>>
>>>>> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
>>>>> SLF4J: Defaulting to no-operation (NOP) logger implementation
>>>>> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for
>> further
>>>>> details.
>>>>>
>>>>
>>>
>>>
>>
