[ https://issues.apache.org/jira/browse/WHIRR-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229057#comment-13229057 ]
Andrei Savu commented on WHIRR-391: ----------------------------------- +1 for committing to 0.7 after changing INSTANCES.containsKey("config") to INSTANCES.containsKey(config) in HadoopServiceController. I will go through the patch one more time later today. For 0.8.0 I think we need a different more clean approach. I would love to be able to replace: {noformat} +# Change the number of machines in the cluster here +whirr.instance-templates=1 hadoop-namenode+yarn-resourcemanager+mapreduce-historyserver,1 hadoop-datanode+yarn-nodemanager + +# We need to use modified scripts for the installation since it has changed +# significantly since 0.20.x +whirr.java.install-function=install_oracle_jdk6 +whirr.hadoop.install-function=install_cdh_hadoop +whirr.hadoop.configure-function=configure_cdh_hadoop +whirr.yarn.configure-function=configure_cdh_yarn +whirr.yarn.start-function=start_cdh_yarn +whirr.mr_jobhistory.start-function=start_cdh_mr_jobhistory +whirr.env.repo=cdh4 {noformat} ... with ... {noformat} whirr.instance-templates=1 cdh-yarn-namenode+cdh-yarn-resourcemanager+cdh-yarn-mapreduce-historyserver, 1 cdh-yarn-hadoop+cdh-yarn-nodemanager {noformat} This is less error prone and more consistent. I think we should view the ability to override install / configure functions as an advanced feature not a common mechanism for installing different flavors. > Write a YARN (Hadoop MR2) service for Whirr > ------------------------------------------- > > Key: WHIRR-391 > URL: https://issues.apache.org/jira/browse/WHIRR-391 > Project: Whirr > Issue Type: New Feature > Components: new service, service/hadoop > Reporter: Tom White > Assignee: Tom White > Fix For: 0.8.0, 0.7.2 > > Attachments: WHIRR-391-0.7.1.patch, WHIRR-391-0.7.1.patch, > WHIRR-391-0.7.patch, WHIRR-391.patch, WHIRR-391.patch, WHIRR-391.patch, > WHIRR-391.patch, WHIRR-391.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira