[ https://issues.apache.org/jira/browse/WHIRR-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436844#comment-13436844 ]
Tom White commented on WHIRR-630: --------------------------------- Looks good. The only thing I noticed was the use of Optional<String> in ClusterSpec, which is inconsistent with other optional values. Also, getBlobStoreEndpoint() returns a Optional<String> and setEndpoint() takes a String, which is not the normal beans pattern. How about having getBlobStoreEndpoint() return a String and getOptionalBlobStoreEndpoint() return a Optional<String>? This would allow us to add optional getters for the other optional values in a compatible way at a later point. > add property endpoint > --------------------- > > Key: WHIRR-630 > URL: https://issues.apache.org/jira/browse/WHIRR-630 > Project: Whirr > Issue Type: Improvement > Components: core > Affects Versions: 0.8.0 > Reporter: Adrian Cole > Assignee: Adrian Cole > Fix For: 0.8.0 > > Attachments: WHIRR-630.patch > > Original Estimate: 4h > Remaining Estimate: 4h > > In all private clouds, the user needs to supply the cloud endpoint url to > connect to. Currently, Whirr has no means to supply this, outside diverting > to jclouds-specific property "jclouds.endpoint" or "providername.endpoint" > The impact is that the CLI and other tools neither document, nor make easy > supplying this. For example, a user should intuitively be able to supply > --endpoint http://keystonehost/v2.0/ for openstack, but right now, it is > essentially a secret! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira