[
https://issues.apache.org/jira/browse/WHIRR-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485597#comment-13485597
]
Graham Gear commented on WHIRR-675:
-----------------------------------
Good point, although given the WHIRR-675_VERSION_1.patch implementation assumed
the default JVM locale, perhaps it is suffcient to allow this to be set by the
standard means available and not introduce any locale specific porcessing? Eg.
- Set OS/Environment/Java Console Locale
- Set as part of the whirr JVM command line system properties (WHIRR_CLI_OPTS)
The other option would involve defining a locale in the whirr configuration and
setting explicitly in the bootstrap code of whirr (Locale.setDefault) and
ignoring the system set Locale properties.
I prefer the first option, which feels less obtrusive and invovles a smaller
footprint patch.
What do we think?
> Convert all whirr.env.* environment variable labels to upper case
> -----------------------------------------------------------------
>
> Key: WHIRR-675
> URL: https://issues.apache.org/jira/browse/WHIRR-675
> Project: Whirr
> Issue Type: Improvement
> Reporter: Graham Gear
> Priority: Minor
> Attachments: WHIRR-675_VERSION_1.patch
>
>
> This allows the java properties file and shell environment variables
> conventions to be maintained. Eg
> whirr.env.repo=cdh4
> whirr.env.repocm=cm4
> whirr.env.repo_host=10.177.196.145/tmph3l7m2vv103/cloudera-repos
> converts to
> REPO=cdh4
> REPOCM=cm4
> REPO_HOST=10.177.196.145/tmph3l7m2vv103/cloudera-repos
> This will remove common configuration errors including ones in the existing
> codebase
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
