if we do remove it we should keep the attached flag and provide setters/getters for it so that users dont have to add their own boolean - something like markAttached() isAttached()
other then that i am all for removing it -igor On 10/7/07, Matej Knopp <[EMAIL PROTECTED]> wrote: > Also this would mean preserving page.onAttach, which would be the > first method called after page is taken from session, so that if user > need this event, they would get it (from there they can even cascade > it to other components, but we wouldn't do it by default). > > -Matej > > On 10/7/07, Matej Knopp <[EMAIL PROTECTED]> wrote: > > Hi, > > > > what good is the onAttach method? We shouldn't encourage users > > initializing data upfront, as they should do it lazily on first > > demand. Attaching is also unreliable as when first time the page is > > attached, components inside repeaters aren't even built yet. > > > > So I think we should remove onAttach while we can. The benefit would > > be that the code would get less bloated and we'd also save quite a few > > traversals (look at MarkupContainer.internalAttach2(). Looks rather > > scary). > > > > -Matej > > >
