Hold on, the raw input _must_ be preserved after rendering. Where else would we keep invalid input? The code also doesn't make sense - there is no reason why it shouldn't work, except when the page was submitted before the render and the submit was not validated. Am I missing something?
-Matej On 10/20/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > i hope now that nobody is using the form as a tmp holding area which > we told people they could do from version 1.1 or something ! > temp storage like go from page x to y then back again. i gues that > still works? we only clear the pages that are really rendered again? > or all of them that are used in a request? > > On 10/20/07, Eelco Hillenius (JIRA) <[EMAIL PROTECTED]> wrote: > > > > [ > > https://issues.apache.org/jira/browse/WICKET-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > ] > > > > Eelco Hillenius resolved WICKET-1090. > > ------------------------------------- > > > > Resolution: Fixed > > > > > clean up raw_input after rendering of form components > > > ----------------------------------------------------- > > > > > > Key: WICKET-1090 > > > URL: https://issues.apache.org/jira/browse/WICKET-1090 > > > Project: Wicket > > > Issue Type: Bug > > > Affects Versions: 1.3.0-beta1, 1.3.0-beta2, 1.3.0-beta3, 1.3.0-beta4 > > > Reporter: Eelco Hillenius > > > Assignee: Eelco Hillenius > > > Fix For: 1.3.0-beta5 > > > > > > > > > This code doesn't work like it should: > > > super("createUserForm", new CompoundPropertyModel(bean)); > > > final TextField passwordField = new TextField("password"); > > > passwordField.setOutputMarkupId(true); > > > passwordField.setLabel(new ResourceModel("label.createuser.password")); > > > add(passwordField); > > > add(new AjaxLink("generatePasswordLink") { > > > @Override > > > public void onClick(AjaxRequestTarget target) { > > > bean.setPassword(PasswordGenerator.generate().toString()); > > > target.addComponent(passwordField); > > > } > > > }); > > > It should update the label with the new password, but it doesn't when done > > after a form submit since it still has the raw_input value it got from that > > last form submit. There is no reason (as far as I know) to hold on to that > > value after rendering, so the fix is to clean the raw_input at the end of > > requests (i.e. onAfterRender). > > > > -- > > This message is automatically generated by JIRA. > > - > > You can reply to this email to add a comment to the issue online. > > > > >
