Martijn Vos wrote:
Thanks for the response. I've just attached my patch to the bug issue.
I just realised two things:
Firstly, it's not necessary to break compatibility with the old
ImageMap. The old
ImageMap requires that it's linked to an <img> tag, whereas my new version
requires it to be linked to a <map> tag, while an Image takes care of
the <img>
tag. I don't think it'd be too hard for ImageMap to check whether it's
dealing
with an <img> or a <map> tag, and provide the old or new bahaviour based on
that check. This would make it easier to adopt the new ImageMap without
breaking old code. I'd like some feedback on whether people would appreciate
this.
Secondly, the ImageMap is not using a Model. I don't fully grasp Wicket's
Models yet, but I think I'm going to need one for my own ImageMap, so I'll
probably rewrite the ImageMap to enable to use of a Model.
In other words, I'll probably be submitting a couple more patches for
ImageMap
in the future. Should I attach these to the same Jira issue, or should I
make new
Jira issues for this?
mcv.
