Did you ever create it in jira? Frank
On Wed, Apr 2, 2008 at 9:18 AM, Frank Bille <[EMAIL PROTECTED]> wrote: > Noted. > > Frank > > On Wed, Apr 2, 2008 at 8:33 AM, Martijn Dashorst > > > <[EMAIL PROTECTED]> wrote: > > I see... Perhaps 1.3.3 is better... should make it a big release note > though! > > > > > > > > On 4/2/08, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > > > I is currently working fine if inheritance is just one level deep. But > > > if it is 2 or more level deep than each higher level gets inserted > > > after the first <wicket:head>. E.g. > > > > > > <script href="basebase.css"/> > > > <script href="base.css"/> > > > > > > <script href="basebase.css"/> > > > <-- gets inserted here ><script href="extension.css"/> > > > <script href="base.css"/> > > > > > > should be like > > > <script href="basebase.css"/> > > > <script href="base.css"/> > > > <script href="extension.css"/> > > > > > > > > > Juergen > > > > > > > > > On Tue, Apr 1, 2008 at 11:31 PM, Martijn Dashorst > > > <[EMAIL PROTECTED]> wrote: > > > > I'd err on the side of caution. I'd like it to go into 1.4. > > > > > > > > Martijn > > > > > > > > > > > > > > > > On 4/1/08, Johan Compagner <[EMAIL PROTECTED]> wrote: > > > > > how was it now exactly with css? > > > > > pretty random or mixed? or was it now that derived first (in > order) to base > > > > > last? (so is it exactly reversed) > > > > > or is it that it was a bit more random? > > > > > > > > > > If it was pretty random then it can go in 1.3.3, dont know about > the exact > > > > > reverse then i guess we could wait for 1.4 (generic release with > a milestone > > > > > build first) > > > > > > > > > > > > > > > johan > > > > > > > > > > > > > > > > > > > > On Tue, Apr 1, 2008 at 10:43 PM, Juergen Donnerstag < > > > > > [EMAIL PROTECTED]> wrote: > > > > > > > > > > > I have a fix for that and our junit tests are still ok with > it. But as > > > > > > always, some existing apps might behave differently because > the order > > > > > > of the css links will change (base first, derived last). > Should that > > > > > > go in before 1.3.3? > > > > > > > > > > > > Juergen > > > > > > > > > > > > > > > > > > > > > > > > > > Begin forwarded message: > > > > > > > > From: "Matej Knopp" <[EMAIL PROTECTED]> > > > > > > > > Date: March 25, 2008 11:51:20 AM PDT > > > > > > > > To: [EMAIL PROTECTED] > > > > > > > > Subject: Re: Bug in order of rendered links within > <wicket:head> ? > > > > > > > > Reply-To: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > I agree that we should. But I'm not sure why the order is > like this. > > > > > > > > Juergen? > > > > > > > > > > > > > > > > -Matej > > > > > > > > > > > > > > > > On Tue, Mar 25, 2008 at 7:43 PM, Igor Vaynberg < > > > > > > [EMAIL PROTECTED] > > > > > > > > > wrote: > > > > > > > >> matej? do we guarantee the order? looks like we should? > > > > > > > >> > > > > > > > >> -igor > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> On Tue, Mar 25, 2008 at 11:36 AM, Justin Morgan - Logic > Sector > > > > > > > >> <[EMAIL PROTECTED]> wrote: > > > > > > > >>> Still wondering if anyone has any input on this...? > Thanks for any > > > > > > > >>> help! > > > > > > > >>> > > > > > > > >>> To clarify, the pages are specified like so... > > > > > > > >>> > > > > > > > >>> AbstractMasterPage ( <-- extends WebPage) > > > > > > > >>> <wicket:head> > > > > > > > >>> <link type="text/css" rel="stylesheet" > href="css/ > > > > > > > >>> AbstractMasterPage.css"/> > > > > > > > >>> </wicket:head> > > > > > > > >>> > > > > > > > >>> AbstractStaticTextPage ( <-- extends > AbstractMasterPage) > > > > > > > >>> <wicket:head> > > > > > > > >>> <link type="text/css" rel="stylesheet" > href="css/ > > > > > > > >>> AbstractStaticTextPage.css"/> > > > > > > > >>> </wicket:head> > > > > > > > >>> > > > > > > > >>> StaticTextPage ( <-- extends AbstractStaticTextPage) > > > > > > > >>> <wicket:head> > > > > > > > >>> <link type="text/css" rel="stylesheet" > href="css/ > > > > > > > >>> StaticTextPage.css"/> > > > > > > > >>> </wicket:head> > > > > > > > >>> > > > > > > > >>> But in the rendered HTML, the CSS links show up in the > *wrong > > > > > > > >>> order*: > > > > > > > >>> > > > > > > > >>> <head> > > > > > > > >>> <link href="css/AbstractMasterPage.css" > type="text/css" > > > > > > > >>> rel="stylesheet"/> > > > > > > > >>> <link href="css/StaticTextPage.css" > type="text/css" > > > > > > > >>> rel="stylesheet"/> > > > > > > > >>> <link href="css/AbstractStaticTextPage.css" > type="text/ > > > > > > > >>> css" rel="stylesheet"/> > > > > > > > >>> </head> > > > > > > > >>> > > > > > > > >>> This results in parent-CSS overriding child-CSS, which > is wrong. > > > > > > > >>> > > > > > > > >>> Thanks again for any help! > > > > > > > >>> > > > > > > > >>> > > > > > > > >>> > > > > > > > >>> On Mar 25, 2008, at 1:19 AM, Justin Morgan - Logic > Sector wrote: > > > > > > > >>>> I'm having an issue with links to CSS files in Wicket > 1.3.1. The > > > > > > > >>>> problem is the ordering of the links in the rendered > HTML. The > > > > > > > >>>> page > > > > > > > >>>> inheritance hierarchy goes like this: > > > > > > > >>>> AbstractMasterPage --> AbstractStaticTextPage --> > StaticTextPage > > > > > > > >>>> > > > > > > > >>>> However, the list of links brought in via the > <wicket:head> > > > > > > section > > > > > > > >>>> are: > > > > > > > >>>> <link from AbstractMasterPage> > > > > > > > >>>> <link from StaticTextPage > > > > > > > > >>>> <link from AbstractStaticTextPage > > > > > > > > >>>> > > > > > > > >>>> This is causing problems because of the way CSS > inheritance works > > > > > > > >>>> with regard to CSS import order. In other words, it > means that > > > > > > the > > > > > > > >>>> AbstractStaticTextPage CSS link is overriding the > contents of the > > > > > > > >>>> StaticTextPage CSS link. This is the reverse of the > way I think > > > > > > it > > > > > > > >>>> *should* work (I want CSS declarations in > StaticTextPage to > > > > > > > >>>> override > > > > > > > >>>> AbstractStaticTextPage, as you'd expect). > > > > > > > >>>> > > > > > > > >>>> Any ideas? Thanks for any help! > > > > > > > >>>> > > > > > > > >>>> Justin > > > > > > > >>>> > > > > > > > >>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Buy Wicket in Action: http://manning.com/dashorst > > > > Apache Wicket 1.3.2 is released > > > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2 > > > > > > > > > > > > > -- > > > > > > Buy Wicket in Action: http://manning.com/dashorst > > Apache Wicket 1.3.2 is released > > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2 > > >
