2008/5/17 Gerolf Seitz <[EMAIL PROTECTED]>:

> ah, good to know. thanks.
> unfortunately, it doesn't work with the packaging type "pom",
> because there is no compile phase for this packaging type.
>

yes - it's more for actual artifact types like war rather than
pom packaging, normally you don't want it to do anything
for module poms

btw, are you applying the patch to the current wicket trunk?
if so I'll check it out tomorrow and see what's going wrong
(it's 2am here in KL and my wife wants to get some sleep)

Gerolf
>
> On Fri, May 16, 2008 at 7:44 PM, Stuart McCulloch <
> [EMAIL PROTECTED]> wrote:
>
> > 2008/5/17 Gerolf Seitz <[EMAIL PROTECTED]>:
> >
> > > right, i only tried "mvn install" on a particular project ;)
> > >
> > > the problem is that maven-bundle-plugin doesn't generate a manifest,
> > > because the parent pom has an unsupported value for <packaging>,
> > > (only jar and bundle are supported).
> > >
> >
> > FYI, you can enable other packaging types using:
> >
> >  <configuration>
> >    <supportedProjectTypes>
> >      <param>jar</param>
> >      <param>bundle</param>
> >      <param>war</param>
> >      <!-- etc -->
> >    </supportedProjectTypes>
> >  </configuration>
> >
> > more options are covered in the online docs:
> >
> >   http://felix.apache.org/site/maven-bundle-plugin-bnd.html
> >
> > it should be possible to set things up to avoid having to add
> > the plugin manually to every sub-project (as that's a real pain)
> > - it's one of the reasons we added this setting
> >
> > if you need any help just reply to this thread, or send a note
> > to the Felix mailing list with any relevant info / maven logs
> >
> > so i guess we'll have to include the plugin manually for every submodule.
> > >
> > > or is it possible to tell the parent pom to only include the
> > bundle-plugin
> > > for submodules?
> > >
> > >  Gerolf
> > >
> > > On Fri, May 16, 2008 at 5:33 PM, Frank van Lankvelt <
> > > [EMAIL PROTECTED]> wrote:
> > >
> > > > Could you help out with applying this patch?  Simply applying it to
> the
> > > > parent pom breaks my "mvn install".  Do I need to change the
> packaging
> > > > in the sub-projects to "bundle"?
> > > >
> > > > thanks, Frank
> > > >
> > > > On Fri, 2008-05-16 at 17:04 +0200, Gerolf Seitz wrote:
> > > > > hey,
> > > > >
> > > > > I was wondering whether we should follow the recent trend and
> include
> > > > > OSGi metadata with our releases?
> > > > > we could do this unobtrusively with the
> > > > org.apache.felix:maven-bundle-plugin
> > > > > plugin.
> > > > > see the patch at the end of this mail.
> > > > >
> > > > > wdyt?
> > > > >
> > > > >  Gerolf
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > Index: pom.xml
> > > > > ===================================================================
> > > > > --- pom.xml    (revision 650770)
> > > > > +++ pom.xml    (working copy)
> > > > > @@ -545,6 +545,11 @@
> > > > >                      </execution>
> > > > >                  </executions>
> > > > >              </plugin>
> > > > > +            <plugin>
> > > > > +                <groupId>org.apache.felix</groupId>
> > > > > +                <artifactId>maven-bundle-plugin</artifactId>
> > > > > +                <inherited>true</inherited>
> > > > > +            </plugin>
> > > > >          </plugins>
> > > > >
> > > > >          <pluginManagement>
> > > > > @@ -615,6 +620,7 @@
> > > > >
> > > > >
> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> > > > >
> > > > >
> > <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> > > > >                              </manifest>
> > > > > +
> > > > >
> > > >
> > >
> >
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> > > > >                              <manifestEntries>
> > > > >                              </manifestEntries>
> > > > >                          </archive>
> > > > > @@ -694,6 +700,19 @@
> > > > >                      </executions>
> > > > >                      <inherited>true</inherited>
> > > > >                  </plugin>
> > > > > +                <plugin>
> > > > > +                    <groupId>org.apache.felix</groupId>
> > > > > +                    <artifactId>maven-bundle-plugin</artifactId>
> > > > > +                    <executions>
> > > > > +                        <execution>
> > > > > +                            <id>bundle-manifest</id>
> > > > > +                            <phase>process-classes</phase>
> > > > > +                            <goals>
> > > > > +                                <goal>manifest</goal>
> > > > > +                            </goals>
> > > > > +                        </execution>
> > > > > +                    </executions>
> > > > > +                </plugin>
> > > > >              </plugins>
> > > > >          </pluginManagement>
> > > > >      </build>
> > > > --
> > > > -------------------------------------------------------------
> > > > Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam
> +31(0)20-5224466
> > > > San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA
> > > > 94952-3329 +1 (707) 773-4646
> > > > -------------------------------------------------------------
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > Cheers, Stuart
> >
>



-- 
Cheers, Stuart

Reply via email to