They may not be blockers, but they do fix important bugs and the longer they stay uncommitted, the better the chance of conflicts. I'd rather they get into the tree so other massive changes don't cause extra work.
All my work on these patches is based on the 1.4 trunk and my code is already migrated to 1.4. It doesn't help me to have the bugs fixes in a tree other than the 1.4 tree. I spent the better part of last week tracking down and fixing these bugs. I don't want to see this work go to waste. Can you please take a look at these patches? It would be a shame to miss the 1.4 release altogether, which is what you seem to be suggesting. Thanks, -Doug Johan Compagner wrote: > > those are not blockers for an 1.4 M release. > > I can see that we should try to fix it for a release of 1.3 but not for a > Milestone release for 1.4 > it can come after that. > 1.4 Milestone releases are for generics > > > On Mon, May 19, 2008 at 4:00 PM, Doug Donohoe <[EMAIL PROTECTED]> wrote: > >> >> I vote not to. I have submitted two outstanding patches that have not >> been >> committed yet. These patches fix a total of 4 bugs. >> >> https://issues.apache.org/jira/browse/WICKET-1627 (includes 1624 and >> 1580) >> https://issues.apache.org/jira/browse/WICKET-1643 >> >> The longer these patches are not committed, the harder it is for me to >> continue to contribute to wicket since my tree is out-of-sync with the >> main >> tree. >> >> -Doug >> >> >> Frank Bille wrote: >> > >> > Hi all, >> > >> > Second milestone release of Wicket 1.4 has been build. >> > >> > The distribution artifacts can be downloaded from here: >> > >> http://people.apache.org/~frankbille/releases/apache-wicket-1.4-m2/dist/<http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.4-m2/dist/> >> > >> > The maven staging repository can be found here: >> > >> http://people.apache.org/~frankbille/releases/apache-wicket-1.4-m2/m2-repo/<http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.4-m2/m2-repo/> >> > >> > There is also a RAT report for the distribution: >> > >> http://people.apache.org/~frankbille/releases/apache-wicket-1.4-m2/apache-wicket-1.4-m2.rat<http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.4-m2/apache-wicket-1.4-m2.rat> >> > >> > The artifacts has been signed with my (Frank Bille) public key which >> > can be found in the keys file: >> > >> http://people.apache.org/~frankbille/releases/apache-wicket-1.4-m2/KEYS<http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.4-m2/KEYS> >> > >> > >> > I have tested the following: >> > * "mvn clean install" the distribution/src >> > * Check the RAT file. Can't see anything new >> > * Various testing in wicket-examples (winxp+ie6, winxp+ie7, >> macosx+safari) >> > >> > >> > Frank >> > >> > [ ] +1 Release Apache Wicket 1.4 Milestone 2 >> > [ ] -1 Don't release, because... >> > >> > >> >> -- >> View this message in context: >> http://www.nabble.com/-VOTE--Release-Apache-Wicket-1.4-M2-tp17308649p17316717.html >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > -- View this message in context: http://www.nabble.com/-VOTE--Release-Apache-Wicket-1.4-M2-tp17308649p17322136.html Sent from the Wicket - Dev mailing list archive at Nabble.com.
