Stuart, again, thanks a lot. i will file a jira issue for the maven-bundle-plugin.
regards, Gerolf On Tue, May 20, 2008 at 6:20 AM, Stuart McCulloch < [EMAIL PROTECTED]> wrote: > 2008/5/20 Gerolf Seitz <[EMAIL PROTECTED]>: > >> Hi Stuart, >> >> may I ask for your help again? >> >> there is a folder in wicket-datetime >> (src/main/java/org/apache/wicket/extensions/yui/yahoo-dom-event) >> with a single javascript file, which i suspect is the cause for the >> invalid >> manifest. >> >> in Import-Package + Export-Package header: >> org.apache.wicket.extensions.yui.yahoo-dom-event;version="1.4.0.SNAPSHOT" >> >> do we have to "exclude" this folder in the manifest somehow? >> or is it possible to not include it in the *-Package headers, but include >> it >> >> with a different header (like something like "Include-Resource"). >> > > Yes, the manifest goal uses the Bnd tool to scan the package folders > in the output directory and sets them as the default Export-Package. > Currently it doesn't filter out invalid package names, but you can do > this manually by setting Export-Package in the sub-project pom. > > You don't need to use Include-Resource, because this is a build-time > instruction to the Bnd tool to pull in resources when it is assembling > the bundle itself, whereas here we're just using Bnd for the manifest. > > Here's a patch to remove the invalid entry: > > #################################################################### > Index: wicket-datetime/pom.xml > =================================================================== > --- wicket-datetime/pom.xml (revision 658095) > +++ wicket-datetime/pom.xml (working copy) > @@ -43,4 +43,21 @@ > <artifactId>joda-time</artifactId> > </dependency> > </dependencies> > + > + <build> > + <plugins> > + <plugin> > + <groupId>org.apache.felix</groupId> > + > <artifactId>maven-bundle-plugin</artifactId> > + <configuration> > + <instructions> > + <Export-Package> > + > !org.apache.wicket.extensions.yui.yahoo-dom-event,* > + </Export-Package> > + </instructions> > + </configuration> > + </plugin> > + </plugins> > + </build> > + > </project> > #################################################################### > > could you also raise an issue on JIRA against the maven-bundle-plugin: > > https://issues.apache.org/jira/browse/FELIX/component/12311143 > > to get it to automatically remove invalid packages from the calculated > list. > > HTH > > thx in advance, >> Gerolf >> >> On Mon, May 19, 2008 at 11:17 PM, Gerolf Seitz (JIRA) <[EMAIL PROTECTED]> >> wrote: >> >> > >> > [ >> > >> https://issues.apache.org/jira/browse/WICKET-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598101#action_12598101 >> ] >> > >> > Gerolf Seitz commented on WICKET-1645: >> > -------------------------------------- >> > >> > i think this is because we have a folder (not package) called >> > "yahoo-dom-event" and in the osgi manifest, this is in the import and >> export >> > package header. >> > >> > > Syntactic errors in the manifest OSGi headers >> > > --------------------------------------------- >> > > >> > > Key: WICKET-1645 >> > > URL: >> https://issues.apache.org/jira/browse/WICKET-1645 >> > > Project: Wicket >> > > Issue Type: Bug >> > > Components: wicket-datetime >> > > Affects Versions: 1.4-M2 >> > > Reporter: Jawher Moussa >> > > Assignee: Gerolf Seitz >> > > >> > > Hello, >> > > Not exactly sure about the error location, but upon deployment on a >> > OSGi container (SpringSource Application Context, based on Equinox), I >> get >> > the following trace: >> > > [2008-05-19 19:39:26.041] fs-watcher <SPOP0004W> The >> bundle >> > >> '/home/djo/Java/servers/springsource-ap-1.0.0.beta3/repository/bundles/usr/wicket-datetime-1.4-m2.jar' >> > could not be provisioned is its manifest is malformed. The error >> encountered >> > whilst parsing the manifest was: The manifest identified by Name 'Wicket >> > Date/Time', Symbolic Name 'org.apache.wicket.wicket-datetime', and >> Version >> > '1.4.0.m2' has the following errors >> [org.antlr.runtime.NoViableAltException >> > on 'Package Header [Import]' at Char: >> > 768,org.antlr.runtime.NoViableAltException on 'Package Header [Export]' >> at >> > Char: 101] >> > >> > -- >> > This message is automatically generated by JIRA. >> > - >> > You can reply to this email to add a comment to the issue online. >> > >> > >> > > > > -- > Cheers, Stuart
