Looks good,
Stefan Fußenegger wrote: > > - I wouldn't use an extra class just to wrap a HashMap of PageStore. I > would just put them into the plain session. But finally, this is just a > matter of taste. I even think that this class lacks proper > synchronization. Doesn't Terracotta complain about modifying an instance > outside of a transaction?? > I disagree, I think it makes the code cleaner as all the stuff to do with creating PageStores (and debug information) is encapsulated in the class. I don't think that the synchronisation is an issue, im not sure what you mean about terracotta complaining, if Ari is still watching this thread then he can probably answer the question. It is a pain that you cant get the last element of the list, but your solution works well, I tweaked it slightly to remove a not needed if statement (you dont need to check the page id, the subset stuff takes care of it). I'm gonna put this slightly modified class through our test environment here where i work and throw loads of simulated users at it to see how it works. I have removed the wicket module from my terracotta config as this currently forces the use of httpsessionstore. Also with our solution we only need to instrument 4 classes so i'm not using the IClusterable thing in the config, i'm just declaring the classes manually. I would be good to find out how we go about modifying the wicket tim (probably another question for Ari there). I downloaded the terracotta source but couldn't get it to build. Richard -- View this message in context: http://www.nabble.com/Terracotta-integration-tp18168616p18335111.html Sent from the Wicket - Dev mailing list archive at Nabble.com.
