I had a more thorough look into it now and there are some issues I'd like to address: - wouldn't it be better to lift wicketstuff-dojo to dojo 1.0 and keep it as dependency to wicketstuff-push? otherwise there are two seperate dojo versions and if you use ws-dojo and ws-push you end up in a whole mess of javascript libraries - where in your code do you reference the new dojo libraries? i only found resourcereferences in the copied and shortened class AbstractDefaultDojoBehavior that point to /dev/null i.e. to references that aren't existing, leading to wicket throwing errors and to not being able to use dojo at all ... - you sometimes used generics for e.g. hashmaps - i think (but i'm not sure) that all wicket and wicketstuff versions lower than wicket 1.4. should be java 1.4 compatible and generics came with java 5 ... well i don't care, i'm using java 6, but i think there might be a few that do care :-) - speaking of users, although there's now a branch for the 1.3.0 version existing, i think that might confuse or upset wicketstuff-push users as you're only chance to get wicketstuff-push is to check it out from svn. so keeping up-to-date with their version (i.e. 1.3.0) isn't easy as they would have to switch to the branched version ... which they don't know existing ... so shouldn't that whole upgrade thing rather be a separate project?
and the servlet and service problem i mentioned in an earlier post (in the other push thread, i think) ... regards, Michael Rodolfo Hansen-2 wrote: > > No problem, thats why I bumped the version number. > > I still need to debug the RemoveListener, haven't been able to get in > touch > with the guy from jetty, and I'll fix the examples as the only real > incompatibility is that there is no longer a dependency on > wicketstuff-dojo. > > > On Fri, Aug 15, 2008 at 1:31 PM, Michael Sparer > <[EMAIL PROTECTED]>wrote: > >> >> I appreciate the upgrade and am certainly going to do the upgrade for my >> app >> and report errors etc. I hope you don't mind that I took the liberty of >> proposing a branch to have a ready-to-run version with the prior release >> of >> cometd and dojo (see >> >> http://www.nabble.com/Permission-for-branching-wicketstuff-push-to19002588.html >> ) >> >> regards, >> Michael >> >> >> Rodolfo Hansen-2 wrote: >> > >> > Hey guys, >> > >> > I was talking in irc about updating wicketstuff-push to support the >> more >> > recent versions of the bayeux protocol and cometd servlets. >> > >> > So I endeded up with access to the wicketstuff svn and have just >> uploaded >> > a >> > new preliminary version of wicketstuff-push. >> > >> > there are still some issues and alot of ironing out, but the project >> now >> > works with the latest stable versions of jetty, wicket, cometd, there >> is >> a >> > new feature available where you can listen for a clients disconnect >> from >> a >> > web page (actually cometd session).. >> > >> > the new version is 1.3.4-SNAPSHOT if anyone is interested in cheking it >> > out, >> > or helping me continue the cleanup... >> > >> > >> > Thanks, >> > >> > Rodolfo Hansen. >> > >> > >> >> >> ----- >> Michael Sparer >> http://talk-on-tech.blogspot.com >> -- >> View this message in context: >> http://www.nabble.com/wicketstuff-push-update-tp18765345p19002629.html >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > ----- Michael Sparer http://talk-on-tech.blogspot.com -- View this message in context: http://www.nabble.com/wicketstuff-push-update-tp18765345p19032686.html Sent from the Wicket - Dev mailing list archive at Nabble.com.
