and its unrolled. -igor
On Wed, Jan 28, 2009 at 12:47 AM, Igor Vaynberg <[email protected]> wrote: > nah. let me unroll my change, i think martijn just forgot. > > -igor > > On Wed, Jan 28, 2009 at 12:43 AM, Ate Douma <[email protected]> wrote: >> With these changes in the root pom.xml, wicket-examples no longer is >> bundling any one of these and is therefore not standard deployable anymore >> :( >> >> Not sure what the resolution for this is going to be (I'm inclined to agree >> with Martijn), but for now I'll add explicit <scope>compile</scope> >> dependencies for these three jars in the wicket-examples/pom.xml to make it >> deployable again. >> >> Ate >> >> Igor Vaynberg wrote: >>> >>> hmm. we just changed the slf4j ver and ended up with both in the jar... >>> >>> mvn dependency:tree showed the other one coming from wicket and we do >>> have a dependency management on all slf4j stuff >>> >>> changing scope to provided in wicket's pom fixed it. >>> >>> i am willing to write this one off as a maven bug or something else if >>> you say it should work, so feel free to revert. i will just add >>> exclusions for the time being. >>> >>> -igor >>> >>> On Mon, Jan 26, 2009 at 12:53 PM, Martijn Dashorst >>> <[email protected]> wrote: >>>> >>>> Not true. People need to add a <dependencyManagement> section where >>>> they specify the version of the SLF4J api. This overrules any version >>>> set in our POM. >>>> >>>> If this were true, *all* our dependencies need to become provided, >>>> which is rubbish, since it negates the whole purpose of transitive >>>> dependencies. >>>> >>>> Unless someone comes with a convincing argument, I'm inclined to >>>> revert this one (at least for the slf4j-api jar, the slf4j-log4j12 and >>>> log4j jars are optional imo). >>>> >>>> Martijn >>>> >>>> On Mon, Jan 26, 2009 at 8:31 PM, <[email protected]> wrote: >>>>> >>>>> Author: ivaynberg >>>>> Date: Mon Jan 26 19:31:06 2009 >>>>> New Revision: 737795 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=737795&view=rev >>>>> Log: >>>>> making slf4j deps provided otherwise everyone downstream has to add >>>>> exclusions if using a different ver >>>>> >>>>> Modified: >>>>> wicket/trunk/pom.xml >>>>> >>>>> Modified: wicket/trunk/pom.xml >>>>> URL: >>>>> http://svn.apache.org/viewvc/wicket/trunk/pom.xml?rev=737795&r1=737794&r2=737795&view=diff >>>>> >>>>> ============================================================================== >>>>> --- wicket/trunk/pom.xml (original) >>>>> +++ wicket/trunk/pom.xml Mon Jan 26 19:31:06 2009 >>>>> @@ -318,17 +318,20 @@ >>>>> <groupId>org.slf4j</groupId> >>>>> <artifactId>slf4j-api</artifactId> >>>>> <version>1.4.2</version> >>>>> + <scope>provided</scope> >>>>> </dependency> >>>>> <dependency> >>>>> <groupId>org.slf4j</groupId> >>>>> <artifactId>slf4j-log4j12</artifactId> >>>>> <version>1.4.2</version> >>>>> + <scope>provided</scope> >>>>> </dependency> >>>>> <dependency> >>>>> <groupId>log4j</groupId> >>>>> <artifactId>log4j</artifactId> >>>>> <version>1.2.13</version> >>>>> <optional>true</optional> >>>>> + <scope>provided</scope> >>>>> </dependency> >>>>> <dependency> >>>>> <groupId>org.springframework</groupId> >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Become a Wicket expert, learn from the best: http://wicketinaction.com >>>> Apache Wicket 1.3.5 is released >>>> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3. >>>> >>> >> >> >
