I would prefer you don't commit it.Please attach a patch or quickstart to the jira issue. Thanks.
Juergen On Thu, Feb 26, 2009 at 2:41 PM, Martijn Dashorst <martijn.dasho...@gmail.com> wrote: > I've added this test to a JIRA issue, but I can also commit it. That > would fail the build though... > > I'm not certain what the way to go is to solve this particular issue. > > A naive solution would be to just iterate through the threadlocal and > call detach on each page. > > Can we (I) commit test cases for a bug without a solution? > > Martijn > > > On Thu, Feb 26, 2009 at 2:31 PM, Martijn Dashorst (JIRA) > <j...@apache.org> wrote: >> >> [ >> https://issues.apache.org/jira/browse/WICKET-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> Martijn Dashorst updated WICKET-2130: >> ------------------------------------- >> >> Attachment: wicket-2130.tgz >> >> this tarball creates a wicket test case in >> src/test/java/org/apache/wicket/wicket2130 >> >> untar it in jdk-1.4/wicket >> >> >>> Pages stored in Session.touchedPages aren't detached when part of >>> ModalWindow >>> ----------------------------------------------------------------------------- >>> >>> Key: WICKET-2130 >>> URL: https://issues.apache.org/jira/browse/WICKET-2130 >>> Project: Wicket >>> Issue Type: Bug >>> Components: wicket >>> Affects Versions: 1.3.5, 1.4-RC2 >>> Reporter: Martijn Dashorst >>> Fix For: 1.3.6, 1.4-RC3 >>> >>> Attachments: wicket-2130.tgz >>> >>> >>> Creating a ModalWindow with a Page causes the newly constructed page not to >>> be detached. >>> The page is stored in Session.touchedPages, but that list isn't properly >>> processed at the end of the request for detaching. >>> I'll try to create a testcase for this. >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >> > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com > Apache Wicket 1.3.5 is released > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3. >
