Hello,

Can you please add page parameters to the IRequestTarget logging ?

Its a simple addition to
org.apache.wicket.protocol.http.RequestLogger#getRequestTargetString(IRequestTarget
target) :

so this

        else if (target instanceof IBookmarkablePageRequestTarget)
        {
            IBookmarkablePageRequestTarget pageRequestTarget =
(IBookmarkablePageRequestTarget)target;
            sb.append("BookmarkablePage[");
            sb.append(pageRequestTarget.getPageClass().getName());
            sb.append("]");


becomes

        } else if (target instanceof IBookmarkablePageRequestTarget) {
            IBookmarkablePageRequestTarget pageRequestTarget =
(IBookmarkablePageRequestTarget) target;
            sb.append("BookmarkablePage[");
            sb.append(pageRequestTarget.getPageClass().getName());
            sb.append("(");
            sb.append(pageRequestTarget.getPageParameters());
            sb.append(")]");

and my life is beautiful again.

All jokes aside , i think the page params should be there for logging
purposes.

Thanks,
Alex

Reply via email to