I just committed my first patch with my newfound commit privileges. It was the patch attached to 2170 [1]. A couple of questions:
1 - I checked the code, added some more documentation to it, ran all tests, etc. Since it is only three new classes, it can't really break anything, so that's not the concern. My question is: what do I need to do when accepting code from outside contributors? They attached the patch to a JIRA, and it already included the Apache license headers. Is there anything else that I need to do to cover the legal aspect of the code? 2 - Are there any standards that we have as far as commit messages? For instance, in one job I had, we always put the issue number in brackets at the beginning of a new line, ie: [2170]. I looked at the logs on our repo, and it seemed that we put a line with "Issue: 2170" in the message. Any standards? Thanks! [1] - https://issues.apache.org/jira/browse/WICKET-2170 -- Jeremy Thomerson http://www.wickettraining.com
