On Mon, Apr 27, 2009 at 2:53 AM, Martijn Dashorst <[email protected]> wrote: > -1: > - validation of the archive works, but there is no public key in KEYS > [1] to verify that the fingerprint matches our Igor.
i was wondering where the keys were stored... added > - no release tag in http://svn.apache.org/repos/asf/wicket/tags/wicket-1.3.6 > - no release branch (with modified poms) in > http://svn.apache.org/repos/asf/wicket/releases/wicket-1.3.6 i was going to do this after the release was voted. i am not sure why we create these prior... we do have a tag in svn so creating these will be busy > -0: > - no rat report generated (I've ran rat, and didn't uncover any odd > discrepancies, other than: > - .tomcatplugin, .amateras and velocity.log files are in the distribution the release wiki page didnt have instructions on setting up rat, and i figured you will check it since you have it installed anyways > Did you create the Java 1.4 jars using a 1.4 JDK? (hard to guess from > the manifest, as maven overwrites previously generated jar files when > performing the release) igor.vaynb...@server:~/dev/src/wicket-common$ mvn4 -version Maven version: 2.0.9 Java version: 1.4.2_19 OS name: "linux" version: "2.6.27-11-server" arch: "i386" Family: "unix" igor.vaynb...@server:~/dev/src/wicket-common$ mvn5 -version Maven version: 2.0.9 Java version: 1.5.0_16 OS name: "linux" version: "2.6.27-11-server" arch: "i386" Family: "unix" -igor > If I run mvn5 install on our src distribution and after that a mvn4 > install, I get the following test failures: > testThousandSeperator(org.apache.wicket.util.convert.converters.ConvertersTest) > testParentEscapeSequenceInRenderedHtml(org.apache.wicket.ParentResourceEscapePathTest) > testResourceUrlGeneratedByResourceReference(org.apache.wicket.ParentResourceEscapePathTest) > testRequestHandlingOfResourceUrlWithEscapeStringInside(org.apache.wicket.ParentResourceEscapePathTest) > > Which are due to wrong bindings. If you did use 1.4 to compile the > JDK-1.4 jars, then there's no problem, but if you used JDK 1.5 (or > newer) then we need to roll the release again. > > Martijn > > [1] http://svn.apache.org/repos/asf/wicket/common/KEYS >
