Martijn Dashorst wrote: > On Sun, May 31, 2009 at 10:48 AM, Max Bowsher <[email protected]> wrote: >> DevUtilsPage is modifying the component hierarchy in onBeforeRender, >> which is not allowed IIUC. > > You're remembering it wrong: in yea old days you weren't allowed to > modify component hierarchy in onAttach(). modifying component > hierarchy in onbeforerender is perfectly allowed, and the only option > to modify the hierarchy once a page has been rendered.
Ah, ok. Thanks for the clarification. However, it must still be wrong to do things in onBeforeRender() which are just basic setting up of the component tree to match the markup, and make no sense to redo every render, so I think my previous patch is still correct. Max.
signature.asc
Description: OpenPGP digital signature
