I've committed the patch (I don't like having uncommitted code lying around) to wicket-1.3.x and wicket-1.x. You may still object though, I'll just revert the commits...
Martijn On Thu, Aug 13, 2009 at 5:23 PM, Igor Vaynberg<[email protected]> wrote: > +1 > > -igor > > On Thu, Aug 13, 2009 at 8:19 AM, Martijn > Dashorst<[email protected]> wrote: >> Updated patch with method rename: >> >> Index: src/main/java/org/apache/wicket/RequestCycle.java >> =================================================================== >> --- src/main/java/org/apache/wicket/RequestCycle.java (revision 803876) >> +++ src/main/java/org/apache/wicket/RequestCycle.java (working copy) >> @@ -1124,6 +1124,15 @@ >> } >> } >> >> + try >> + { >> + onAfterTargetsDetached(); >> + } >> + catch (Throwable re) >> + { >> + log.error("there was an error processing >> onAfterTargetsDetached", re); >> + } >> + >> if (automaticallyClearFeedbackMessages) >> { >> // remove any rendered and otherwise obsolete >> feedback messages from >> @@ -1520,6 +1529,13 @@ >> } >> >> /** >> + * Called when the request cycle object has detached all request >> targets. >> + */ >> + protected void onAfterTargetsDetached() >> + { >> + } >> + >> + /** >> * Called when the request cycle object has finished its response >> */ >> protected void onEndRequest() >> > -- Become a Wicket expert, learn from the best: http://wicketinaction.com Apache Wicket 1.4 increases type safety for web applications Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.0
