not sure we can fix this, the markup in datatable changed in 1.4.6 because it had other bugs in it. you will have to recopy the markup.
-igor On Mon, Apr 26, 2010 at 11:06 AM, James Carman <[email protected]> wrote: > I believe I've found a regression. I have a custom subclass of > DataTable and here's its markup (I basically add my own toolbars): > > <wicket:panel> > > <span wicket:id="topToolbars"> > <span wicket:id="toolbar"></span> > </span> > > > <tr wicket:id="rows"> > <td wicket:id="cells"> > <span wicket:id="cell">[cell]</span> > </td> > </tr> > > <span wicket:id="bottomToolbars"> > <span wicket:id="toolbar"></span> > </span> > > </wicket:panel> > > I believe I borrowed that from the original markup file for DataTable. > Anyway, this works in 1.4.5 and when I upgrade to 1.4.6, I get the > following error. I've tried going back and forth and the version that > causes the regression is 1.4.6. > > 04...@13:57:02 ERROR (RequestCycle) - close tag not found for tag: > <span wicket:id="topToolbars" > wicketpath="form_idPaths_table_topToolbars_1_toolbar">. Component: > [MarkupContainer [Component id = toolbar]] > > I would assume it's related to WICKET-2620, but I don't know. > Shouldn't we fix this before we do another release? > > On Mon, Apr 26, 2010 at 1:12 PM, Igor Vaynberg <[email protected]> > wrote: >> this vote is to release wicket 1.4.8 >> >> this maintenance release brings over 20 bug fixes and improvements. >> >> branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.8/ >> >> artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.8/ >> >> changelog: >> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310561&fixfor=12314811 >> (and below) >> >> vote ends Thursday 11am gmt-8 >> >> cheers >> >> -igor >> >> >> Release Notes - Wicket - Version 1.4.8 >> >> >> ** Bug >> * [WICKET-2075] - Pagemap is locked forever with some Page >> serialization exceptions >> * [WICKET-2424] - OnChangeAjaxBehavior + DatePicker do not work together >> * [WICKET-2764] - MarkupCache messed up when using MergedMarkup >> (e.g. for Page markup inheritance) together with IResourceStreams that >> do NOT also implement IFixedLocationResourceStream >> * [WICKET-2767] - DatePicker Calendar: wrong year format when 4 >> digits are used (yyyy), e.g. 2010 --> 0010 >> * [WICKET-2772] - Generate wicketpath attribute for RadioChoice >> * [WICKET-2779] - Submit a nested form via ajax to upload a file >> inside modal window does not work on IE. >> * [WICKET-2787] - ValueMap.getAsBoolean(key, defaultValue) always >> returns false for non-existing keys, instead of the defaultValue >> * [WICKET-2799] - @RequireHttps not switching to https when >> setting response page to non-bookmarkable page >> * [WICKET-2802] - StringIndexOutOfBoundsException in >> PortletServletRequestWrapper for some resource requests >> * [WICKET-2806] - Javascript looking for related radio in group is >> not working if css class is already assigned to radio >> * [WICKET-2822] - Small Bug in JavaDoc for SpringWebApplicationFactory >> >> ** Improvement >> * [WICKET-2771] - Please support "isPrimary" for @SpringBean >> * [WICKET-2776] - Enhancing RadioChoice input items with >> individual title and css class attributes >> * [WICKET-2778] - Set Application ThreadLocal in WicketSessionFilter >> * [WICKET-2796] - Improve error reporting on locked page maps >> * [WICKET-2803] - ListMultipleChoice's Constructors Should Accept >> IModel<? extends Collection<T>> >> * [WICKET-2813] - IndicatingAjaxButton should have construtors >> that take a IModel for the button text as does AjaxButton. >> * [WICKET-2817] - ChoiceGroup's Constructor Should Accept IModel<? >> extends Collection<T>> >> * [WICKET-2821] - More "IModel<? extends Collection<" Fixes >> * [WICKET-2830] - Make >> BookmarkablePageRequestTargetUrlCodingStrategy#encode non final >> * [WICKET-2831] - ConverterLocator#get(Class<T>) shouldn't be final >> * [WICKET-2837] - Inaccurate AjaxSubmitLink Javadoc >> >> ** Wish >> * [WICKET-2847] - Make StringResourceStream non final >> >
