Good point, I used an test case that was in the same package that the component, what invalidate the test. But the described problem remains. I attached in the Jira another test case, in another package...
On Fri, Jul 23, 2010 at 9:06 AM, Johan Compagner <jcompag...@gmail.com>wrote: > yes if you use the package org.apache.wicket!!! > But that is something i definitely dont see as a problem because you > shouldnt do that. > org.apache.wicket is the package of wicket itself (just like java.lang > is of java itself) > > johan > > > On Fri, Jul 23, 2010 at 14:02, Pedro Santos <pedros...@gmail.com> wrote: > > Hi Johan, actually it is 2 overridable protected methods that can execute > an > > rule already implemented by some custom component. > > I attached an test to via Jira site showing the possible problem. > > > > https://issues.apache.org/jira/browse/WICKET-2960 > > > > On Fri, Jul 23, 2010 at 5:38 AM, Johan Compagner <jcompag...@gmail.com > >wrote: > > > >> we (servoy) dont care much about those changes, they can be left in > >> (we dont use it and they also dont give us a problem (after my fix ;) > >> ) > >> > >> > >> the only problem is by the way onInitialize and onConfigure() > >> > >> Because initialize and also doInitialize() are package scope so they > >> are not a problem as far as i know... for example doinitialize() is > >> final but a subclass of component in another package can just create > >> such a method just fine... > >> > >> configure() you made public final.. i think we just should do the > >> same, make it package scope final... > >> then that method shouldnt also be a big problem. > >> > >> The it is just the 2 overridable protected methods onInitialize and > >> onConfigure > >> > >> johan > >> > >> > >> On Thu, Jul 22, 2010 at 19:33, Igor Vaynberg <igor.vaynb...@gmail.com> > >> wrote: > >> > i just thought of something, i added oninitialize and onconfigure > >> > features to 1.4.x as well as trunk, but they can create an > >> > incompatibility for 1.4.x users if they have declared a method on > >> > their components with the same name. > >> > > >> > impacted method names are component#configure(), onConfigure(), > >> > initialize(), onInitialize(). > >> > > >> > should we remove these features from 1.4.x to remove the chance of an > >> > incompatibility? > >> > > >> > -igor > >> > > >> > > > > > > > > -- > > Pedro Henrique Oliveira dos Santos > > > -- Pedro Henrique Oliveira dos Santos
