format is good, patch applied. thanks. -igor
On Fri, Jul 23, 2010 at 6:29 AM, Erich W Schreiner <[email protected]> wrote: > Dear team, > > I have submitted a patch for https://issues.apache.org/jira/browse/WICKET-2812 > > Please verify the format of the patch and let me know if I can improve on it. > > Cheers, > Erich > > PS: I've also mailed the ICLA to the secretary. > > > > > ________________________________ > From: Martijn Dashorst <[email protected]> > To: [email protected] > Sent: Fri, July 23, 2010 1:56:45 PM > Subject: Re: Contributing to Wicket > > On Fri, Jul 23, 2010 at 1:53 PM, James Carman > <[email protected]> wrote: >> Attach some patches to the JIRAs. > > Unified diff is preferred, and be sure to tick the "Allow for inclusion" > button. > > If you're getting serious you can make life for us easier, especially > with larger contributions by submitting an ICLA to the secretary of > The ASF: http://www.apache.org/licenses/icla.txt > > Martijn > >> >> On Fri, Jul 23, 2010 at 7:50 AM, Erich W Schreiner <[email protected]> >>wrote: >>> Dear Wicket team, >>> >>> as I'm using wicket for some time now, I would like to contribute back to >>> the >>> community. An additional motivation is getting to know the insides of Wicket >>> better - and the best way I can imagine is by working on Wicket itself. :-) >>> >>> I have looked at the list of open issues in JIRA and found some that seem to >>be >>> easy to fix. This seems to be a good starting point for me. >>> >>> What are your procedures for letting me submit changes / patches? Is there a >>> link pointing to a description of building Wicket from source >>> (/contribute/building-from-svn.html on wicket.apache.org is broken - and >>> yes, >>I >>> did a forced reload of the page :-) >>> >>> Cheers, >>> Erich >> > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com > Apache Wicket 1.4 increases type safety for web applications > Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.8 >
