It might be called multiple times, it's still better than not calling it at all. Alternatively we could perhaps add a flag on page to prevent forwarding detach to components more then once per requests.
-Matej On Tue, Aug 24, 2010 at 10:33 AM, Michal Kurtak <[email protected]> wrote: > Hi, > > I tried to play with wicket 1.5 M1 and found that detach on a page is > called twice: > > First call stacktrace: > LinkTestPage(Component).detach() line: 1288 > PageProvider.detach() line: 288 > RenderPageRequestHandler.detach(IRequestCycle) line: 131 > RequestCycle(RequestHandlerStack).detach() line: 237 > RequestCycle.detach() line: 444 > > Second call stacktrace: > LinkTestPage(Component).detach() line: 1288 > PersistentPageManager$PersitentRequestAdapter(RequestAdapter).commitRequest() > line: 162 > PersistentPageManager(AbstractPageManager).commitRequest() line: 98 > PageAccessSynchronizer$1(PageManagerDecorator).commitRequest() line: 68 > PageAccessSynchronizer$1.commitRequest() line: 204 > Application$3.onDetach(RequestCycle) line: 1501 > RequestCycle.detach() line: 452 > > Don't know if its a bug or a feature.Did I miss anything? > > BR, > Michal >
