ok, I'll revert that part of the change
thanks for reviewing!

On Fri, Oct 22, 2010 at 9:12 PM, Jeremy Thomerson <[email protected]
> wrote:

> On Fri, Oct 22, 2010 at 2:09 PM, Igor Vaynberg <[email protected]
> >wrote:
>
> > i think only the isinstantiationauthorized should use class<? extends
> > irequestablecomponent>
> >
> > everything else - that gets a concrete instance - should get
> > Component. reason being auth strategy often accesses metadata on
> > component to figure out allowed roles, etc. so either we add metadata
> > to irequestablecomponent - which is weird since there is nothing
> > requestable about it, or we change it back to use concrete Component.
> > im in favor of the latter.
> >
> > -igor
> >
>
> I agree with Igor.  I actually just replied to this commit as well, but
> only
> to the commits@ list, which bounced.
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> *Need a CMS for Wicket?  Use Brix! http://brixcms.org*
>

Reply via email to