I mean only the key name should be dynamic.

Currently it is:
  private static final String NOT_FOUND = "[Warning: Property for
'myKeyNotExsts' not found]";

                   ^^^^^^^^^^^^^^
Few lines below we have:
   log.warn("No value found for wicket:message tag with key: {}", key);

          ^^^^^^^

I.e. we can make it:
  private static final String NOT_FOUND = "[Warning: Property for '%s' not
found]";
and then
getResponse().write(String.format(NOT_FOUND, key));

so it will become the correct one:
"[Warning: Property for '<any key name>' not found]";

What do you think ?


On Tue, Nov 23, 2010 at 9:56 AM, Juergen Donnerstag <
[email protected]> wrote:

> I don't think it's necessary to provide users the option to change the
> warning if a key was not found.  If you really want to, use a
> property. IMO that would be overkill.
>
> Juergen
>

Reply via email to