May I ask which would be the "side effects" of this? I ask because many wiquery users were complaining about things, e.g. tabs, stopping to work properly via AJAX replacement, for different versions of wiquery, after upgrading to 1.4.14. Could this be related?
Regards, Ernesto On Wed, Dec 1, 2010 at 1:34 PM, Johan Compagner <[email protected]> wrote: > This commits breaks all header contributions when the > ajaxrequesttarget has more then 1 component that it must render and > the component after the first one also wants to render something in > the head.. > > i committed a fix: > > commit -m "fix form previous commit: 1031432..." > C:/workspace_wicket14/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java > Sending > C:/workspace_wicket14/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java > Transmitting file data ... > Committed revision 1040980. > > > so that the header is now only closed after all components are rendered. > > Don't we have any test that would cover this? That should have failed? > So a test that renders 2 components in an ajax request and both > contribute some css or js. > > johan > > > On Fri, Nov 5, 2010 at 06:07, <[email protected]> wrote: >> Author: jrthomerson >> Date: Fri Nov 5 05:07:52 2010 >> New Revision: 1031432 >> >> URL: http://svn.apache.org/viewvc?rev=1031432&view=rev >> Log: >> AjaxRequestTarget was not calling IHeaderResponse.close() after traversing >> hierarchy to renderhead on all appropriate iheadercontributors >> >> Modified: >> >> wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java >> >> Modified: >> wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java >> URL: >> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?rev=1031432&r1=1031431&r2=1031432&view=diff >> ============================================================================== >> --- >> wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java >> (original) >> +++ >> wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java >> Fri Nov 5 05:07:52 2010 >> @@ -1143,6 +1143,7 @@ public class AjaxRequestTarget implement >> } >> }); >> } >> + header.getHeaderResponse().close(); >> >> // revert to old response >> >> >> >> >
