What about other folks' custom components and their markup-based test cases? They would start failing if they failed to do this in their code for some reason.
On Thu, Dec 30, 2010 at 5:51 PM, Juergen Donnerstag <[email protected]> wrote: > through true, most components already do it anyway. There is almost no > effect on our test cases > > > On Thu, Dec 30, 2010 at 11:27 PM, Jeremy Thomerson > <[email protected]> wrote: >> On Thu, Dec 30, 2010 at 9:46 AM, Juergen Donnerstag >> <[email protected]> wrote: >>> we have several components which use >>> >>> �...@override >>> protected void onComponentTag(final ComponentTag tag) >>> { >>> if (tag.isOpenClose()) >>> { >>> tag.setType(TagType.OPEN); >>> } >>> super.onComponentTag(tag); >>> } >>> >>> to convert the Component's tag open-close to open-body-close. I wonder >>> whether we should make this the default. It's usually required anyway >>> and it shouldn't harm any component (incl <input>). >>> >>> -Juergen >>> >> >> -0 - it changes the user's markup for no apparent reason >> >> -- >> Jeremy Thomerson >> http://wickettraining.com >> Need a CMS for Wicket? Use Brix! http://brixcms.org >> >
