sounds interesting, but your patch didnt make it. attach to a jira issue? -igor
On Sat, Jan 8, 2011 at 2:54 PM, Juergen Donnerstag <[email protected]> wrote: > Hi, > > currently every component that requires the markup to be in an > associated file must be derived from Panel. Every component that want > it's markup "inline" must be derived from Fragment. I've changed that > and moved the respective source code into something I called markup > sourcing strategy. I'm not sure it's the best name, so feel free to > suggest other names. Such a strategy can be provided to any component > via > > public IMarkupSourcingStrategy getMarkupSourcingStrategy(); > > Obviously it makes sense that only one strategy can be associated with > any component. Each strategy has its own implementations to provide > the correct markup, handle the header contribution, necessary changes > to the open tag and it renders the component body appropriately. > > Changing a FormComponent to a FormComponentPanel is now as simple as > subclassing getMarkupSourcingStrategy(). And it easily be changed to > become a "FormComponentFragment" > > I've attached a patch (draft) against 1.5 trunk which successfully > passes all tests in core. I wonder what you think about the idea. > > -Juergen >
