what bothers me is that there are isenabled(), supports() methods but nothing that really makes use of them. We can provide a FilterFactoryManager class where users can add filters and it can have a simple Request wrap(Request) method that takes care of isenabled() and supports(). or, we simply remove those from the abstract and let users implement whatever scheme they want.
-igor On Sun, Jan 9, 2011 at 10:55 PM, Juergen Donnerstag <[email protected]> wrote: > I had that idea as well. My initial commit actually included such a > hook. But I removed it again. Though wrappers are registered with > filters/servlets in the servlet world, wicket already provides a very > very easy way by subclassung Application.newRequestxx(). > > IMO the problem is, and here I agree with you, that it is kind of > isolated. It's not obvious. Every dev will first look into > WicketFilter but will not find anything. > > May be something like App.newRequestWrapper() would do as well. > > -Juergen > > On Mon, Jan 10, 2011 at 4:39 AM, Igor Vaynberg <[email protected]> > wrote: >> Since we provide AbstractRequestWrapperFactory shouldnt it be plugged >> into wicketfilter somewhere? right now it seems a bit strange that it >> and its friends are so isolated. >> >> -igor >> >
