This is the changelist by Pedro - http://svn.apache.org/viewvc?view=revision&revision=1068226 <http://svn.apache.org/viewvc?view=revision&revision=1068226>AFAIR Hudson had problems. I also tried with your change here and it works with jdk1.5.0_22
On Wed, Mar 30, 2011 at 11:44 PM, Peter Ertl <[email protected]> wrote: > That's strange since I did a full compile of wicket with jdk 5 and all the > test cases worked fine. > > my personal tests also succeeded. > > can you remember what exactly the issue was? > > Am 30.03.2011 um 20:27 schrieb Martin Grigorov: > > > On Wed, Mar 30, 2011 at 9:24 PM, <[email protected]> wrote: > > > >> Author: pete > >> Date: Wed Mar 30 18:24:21 2011 > >> New Revision: 1087031 > >> > >> URL: http://svn.apache.org/viewvc?rev=1087031&view=rev > >> Log: > >> - fixed typo in javadoc > >> - propagate argument type for Args.notNull(...) so chained checking + > >> assigning of argument does not require a cast > >> > >> Modified: > >> > >> > wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java > >> > >> Modified: > >> > wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java > >> URL: > >> > http://svn.apache.org/viewvc/wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java?rev=1087031&r1=1087030&r2=1087031&view=diff > >> > >> > ============================================================================== > >> --- > >> > wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java > >> (original) > >> +++ > >> > wicket/trunk/wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java > >> Wed Mar 30 18:24:21 2011 > >> @@ -29,9 +29,9 @@ public class Args > >> * @param argument > >> * @param name > >> * @return The 'argument' parameter > >> - * @throws IllegalargumentException > >> + * @throws IllegalArgumentException > >> */ > >> - public static Object notNull(final Object argument, final String > >> name) > >> + public static <T> T notNull(final T argument, final String name) > >> > > > > This doesn't work in JDK 1.5 > > Juergen did it exactly like you did it now but then Pedro made it Object > > > >> { > >> if (argument == null) > >> { > >> @@ -46,7 +46,7 @@ public class Args > >> * @param argument > >> * @param name > >> * @return The 'argument' parameter > >> - * @throws IllegalargumentException > >> + * @throws IllegalArgumentException > >> */ > >> public static String notEmpty(final String argument, final String > >> name) > >> { > >> @@ -66,7 +66,7 @@ public class Args > >> * @param max > >> * @param value > >> * @param name > >> - * @throws IllegalargumentException > >> + * @throws IllegalArgumentException > >> */ > >> public static <T extends Comparable<T>> void withinRange(final T > >> min, final T max, > >> final T value, final String name) > >> > >> > >> > > > > > > -- > > Martin Grigorov > > jWeekend > > Training, Consulting, Development > > http://jWeekend.com <http://jweekend.com/> > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
