In short: AttributeModifier can  get a lot simpler:
 - always add the attribute (unless the AM is disabled)
 - the regexp matching functionality needs to go
 - replaceModel needs to become an Object (with instanceof check for models)
 - enabled field should be removed in favor of subclassing and
overriding isEnabled()

This will clean up AttributeModifier considerably—not catering for
extreme use cases.

Martijn

Reply via email to