Does that mean we'll not detect such issues anymore? I'd much rather would like maven or jenkins to run all tests with 2 different locale to make sure it works.
Juergen On Wed, Jul 6, 2011 at 9:16 PM, Bruno Borges <[email protected]> wrote: > Can't someone define a default locale in pom.xml and force reference that > inside wicket tests? > On 2011 7 6 15:30, "Sven Meier" <[email protected]> wrote: >> Yes, it's nice but needs some more work. >> >> I'll file another issue. >> >> Sven >> >> On 07/06/2011 08:26 PM, Martin Grigorov wrote: >>> On Wed, Jul 6, 2011 at 8:19 PM, Sven Meier<[email protected]> wrote: >>>> Sorry, my bad. >>>> >>>> Localizing Duration might be more difficult than I thought (Wicket-3310) >>>> >>>> I'll revert the relevant changes now. >>> Another solution is to set specific locale for the test - en, de or fr. >>> I like that Duration supports this now. We can add more bundles with the > time >>>> Sven >>>> >>>> On 07/06/2011 07:12 PM, Juergen Donnerstag wrote: >>>>> Hi, >>>>> >>>>> though jenkins seems to be fine, maven build is failing on my (German) >>>>> laptop. >>>>> >>>>> ValueMapTest:testGetAs():237:expected "1 Stunde" but was "null" >>>>> DurationTest:operations:74:expected "1,5 minutes" but was "1,5 Minuten" >>>>> DurationTest:locale:108:expected "1 hour" but was "1 Stunde" >>>>> >>>>> would be nice if the dev who changed the code fixes it. >>>>> >>>>> -Juergen >>>> >>> >>> >> >
