yeah, i can do that... -igor
On Fri, Sep 23, 2011 at 8:44 AM, Martijn Dashorst <[email protected]> wrote: > On Fri, Sep 23, 2011 at 5:40 PM, Igor Vaynberg <[email protected]> > wrote: >> ok. lets call this vote failed, get the fixes in, and i will build >> 1.5.2 when all the fixes are in. > > The issue I raised was WICKET-4080, and that is fixed and closed. > Martin fixed WICKET-4068, so we're good to go. > > Can't we re-roll 1.5.1? i.e. svn rm the tag, remove the staging repo, > and run the full release script? > > Martijn > >> >> -igor >> >> >> On Fri, Sep 23, 2011 at 5:10 AM, Martijn Dashorst >> <[email protected]> wrote: >>> That would change my +1 to a -1. >>> >>> I'd also like to include a fix for wicket-event.js where we repair >>> IE's inability to produce proper statechangeevents related to >>> domready. More fixes are always better, and I'd hate to delay 1.5.1, >>> but non-working ajax submits for forms is a blocker IMO >>> >>> Martijn >>> >>> On Fri, Sep 23, 2011 at 11:33 AM, Martin Grigorov <[email protected]> >>> wrote: >>>> unfortunatelly WICKET-4068 had a typo which breaks for Ajax submits on >>>> forms with onsubmit handler >>>> fixed with r1174613 but 1.5.1 has the problem. >>>> >>>> On Fri, Sep 23, 2011 at 11:42 AM, Martijn Dashorst >>>> <[email protected]> wrote: >>>>> +1 >>>>> >>>>> On Tue, Sep 20, 2011 at 6:40 PM, Igor Vaynberg <[email protected]> >>>>> wrote: >>>>>> This vote is to release wicket 1.5.1 >>>>>> >>>>>> Branch >>>>>> http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.1 >>>>>> >>>>>> Artifacts >>>>>> http://people.apache.org/~ivaynberg/wicket-1.5.1/dist/ >>>>>> >>>>>> Maven repo >>>>>> https://repository.apache.org/content/repositories/orgapachewicket-081/ >>>>>> >>>>>> Changelog >>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12315430 >>>>>> >>>>>> This vote ends Friday, September 23rd at 10:00am (GMT-7) >>>>>> >>>>>> Please test the release and offer your vote. >>>>>> >>>>>> The Wicket team! >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Become a Wicket expert, learn from the best: http://wicketinaction.com >>>>> >>>> >>>> >>>> >>>> -- >>>> Martin Grigorov >>>> jWeekend >>>> Training, Consulting, Development >>>> http://jWeekend.com >>>> >>> >>> >>> >>> -- >>> Become a Wicket expert, learn from the best: http://wicketinaction.com >>> >> > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com >
