-1
WICKET-4116 fix broke a bunch of stuff
for example we no longer redirect from /page to /page?0 which causes problems
also querying request handlers for page instance no longer works. most
queries look like this:
if (pageHandler.isPageInstanceCreated())
return (Page)pageHandler.getPage();
public final boolean isPageInstanceCreated() {
return !pageComponentProvider.isNewPageInstance(); }
however, since isNewPageInstance() now caches the initial value of
'true' even though the page provider later did create the instance we
now erroneously assume the page instance was not created.
isNewPageInstance() is a horrible name, it really should be
isPageInstanceCreated(). if we need something like
wasPageInstanceProvided() - to know whether or not page provider was
created with or without a page instance to fix WICKET-4116 then we
should add it
or perhaps simpler names:
Page hasPageInstance() and boolean createdPageInstance()
-igor
On Wed, Oct 12, 2011 at 10:23 AM, Igor Vaynberg <[email protected]> wrote:
> This vote is to release wicket 1.5.2
>
> Branch
> http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5.2
>
> Artifacts
> http://people.apache.org/~ivaynberg/wicket-1.5.2/dist/
>
> Maven repo
> https://repository.apache.org/content/repositories/orgapachewicket-060/
>
> Changelog
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12318078
>
> This vote ends Saturday, October 15 at 10:00am (GMT-7)
>
> Please test the release and offer your vote.
>
> The Wicket team!
>
