Agree.
File a ticket.
Thanks!

On Mon, Dec 19, 2011 at 12:59 PM, Guillaume Smet
<[email protected]> wrote:
> Hello,
>
> In a Resource extending PackageResource (a LessCSS implementation), we
> set the content type on the ResourceStream to text/css.
>
> The problem is that PackageResource overrides it in
> newResourceResponse (starting from line 255 in 1.5.3):
>                        final String contentType;
>                        if (Application.exists())
>                        {
>                                contentType = 
> Application.get().getMimeType(path);
>                        }
>                        else
>                        {
>                                contentType = resourceStream.getContentType();
>                        }
>
> If not null, shouldn't we give the resourceStream's content type a
> higher priority and use Application.get().getMimeType(path) only if it
> is null?
>
> IMHO we should probably have something like that:
> final String contentType = resourceStream.getContentType();
> if (contentType == null && Application.exists())
> {
>        contentType = Application.get().getMimeType(path);
> }
>
> Thanks for your feedback.
>
> --
> Guillaume



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Reply via email to