I see no problem with -1, -2, ... suffixes. I prefer to not touch the successfully voted branch. Renaming 1.5.4-rc1 to 1.5.4 will require additional testing that the packaging is OK
On Tue, Jan 24, 2012 at 11:33 AM, Emond Papegaaij <[email protected]> wrote: > Perhaps we should do it the other way around and release 1.5.4-rc1, which gets > renamed to 1.5.4 if the vote passes? > > On Tuesday 24 January 2012 11:29:21 Martin Grigorov wrote: >> Hi, >> >> I think we did a mistake with reusing 1.5.4 as version. I realize it now... >> Many of us use corporate Maven proxies (Nexus, Artefactory, ...). I >> can easily remove ~/.m2/repository/org/apache/wicket/* locally but I >> cannot do this for my employer's Nexus installation. It is managed by >> a dedicated team. >> I'm not 100% certain but I think our Nexus currently uses 1.5.4 from >> the first build. >> I'll write a ticket to our Nexus admins to delete the jars and >> re-download them. You may do the same if this applies to your company >> too. >> In the future I prefer to use 1.5.4-1, 1.5.4-2, etc. for such re-builds. >> >> On Tue, Jan 17, 2012 at 11:22 AM, Emond Papegaaij >> >> <[email protected]> wrote: >> > -1 >> > >> > I'm sorry to have to cancel this release again, but 1.5.4 contains a >> > regression introduced with WICKET-4256 (see WICKET-4340). If render >> > permissions are revoked on a page, the user will see an empty page, >> > instead of an AccessDeniedPage. >> > >> > I found this regression debugging a failing testcase in wicket-security >> > this morning. It turns out this change got backported to 1.5.x and >> > 1.4.x as well. >> > >> > Regarding the version number, I'd prefer the release to be numbered >> > 1.5.4. We do not need to concern our users with the fact that we failed >> > to release at the first go. The few people that actually tested 1.5.4 >> > will have to nuke their repo's, but that's the risk of testing releases >> > that did not actually got released. Also, 1.5.4.1 is not a valid maven >> > version number, see >> > http://mojo.codehaus.org/versions-maven-plugin/version-rules.html >> > >> > Emond >> > >> > On Monday 16 January 2012 11:04:06 Igor Vaynberg wrote: >> >> This vote is to release wicket 1.5.4.1 (vote for 1.5.4 failed) >> >> >> >> Branch >> >> http://git-wip-us.apache.org/repos/asf/wicket/?p=wicket.git;a=shortlog >> >> ;h=ref s/heads/build/wicket-1.5.4.1 >> >> >> >> Artifacts >> >> http://people.apache.org/~ivaynberg/wicket-1.5.4.1/dist/ >> >> >> >> Maven repo >> >> https://repository.apache.org/content/repositories/orgapachewicket-079 >> >> / >> >> >> >> Changelog >> >> https://issues.apache.org/jira/secure/IssueNavigator.jspa?jqlQuery=fix >> >> Versio n+%3D+%221.5.4%22+AND+project+%3D+WICKET >> >> >> >> This vote ends Thursday, January 19th at 11:00am (GMT-8) >> >> >> >> Please test the release and offer your vote. >> >> >> >> The Wicket team! -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
