yeah, sounds good. -igor
On Tue, Feb 21, 2012 at 10:11 AM, Martin Grigorov <[email protected]> wrote: > That's a good idea! > I think the logic should even go in PackageResourceReference. And the > warning about the missing compressed version of the resource should > become DEBUG > OK ? > > On Tue, Feb 21, 2012 at 5:53 PM, Igor Vaynberg <[email protected]> > wrote: >> why do we need MinifiedAwareJavaScriptResourceReference in a seperate >> class? why not roll it into JavaScriptResourceReference? >> >> -igor >> >> On Tue, Feb 21, 2012 at 4:59 AM, <[email protected]> wrote: >>> Updated Branches: >>> refs/heads/master 99eec004e -> 59da20da4 >>> >>> >>> WICKET-4422 Minimize Wicket's Ajax JavaScript files at build time >>> >>> Revert the indents in the pom.xml files changed by my editor >>> >>> >>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo >>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/59da20da >>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/59da20da >>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/59da20da >>> >>> Branch: refs/heads/master >>> Commit: 59da20da4adb47c575860588c007d87f3a30b4a4 >>> Parents: 99eec00 >>> Author: Martin Tzvetanov Grigorov <[email protected]> >>> Authored: Tue Feb 21 13:58:29 2012 +0100 >>> Committer: Martin Tzvetanov Grigorov <[email protected]> >>> Committed: Tue Feb 21 13:58:29 2012 +0100 >>> >>> ---------------------------------------------------------------------- >>> pom.xml | 2 +- >>> wicket-core/pom.xml | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> ---------------------------------------------------------------------- >>> >>> >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/59da20da/pom.xml >>> ---------------------------------------------------------------------- >>> diff --git a/pom.xml b/pom.xml >>> index 2f3fb84..9409ad0 100644 >>> --- a/pom.xml >>> +++ b/pom.xml >>> @@ -7,7 +7,7 @@ >>> (the "License"); you may not use this file except in compliance with >>> the License. You may obtain a copy of the License at >>> >>> - http://www.apache.org/licenses/LICENSE-2.0 >>> + http://www.apache.org/licenses/LICENSE-2.0 >>> >>> Unless required by applicable law or agreed to in writing, software >>> distributed under the License is distributed on an "AS IS" BASIS, >>> >>> http://git-wip-us.apache.org/repos/asf/wicket/blob/59da20da/wicket-core/pom.xml >>> ---------------------------------------------------------------------- >>> diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml >>> index 96feeb2..c007e17 100644 >>> --- a/wicket-core/pom.xml >>> +++ b/wicket-core/pom.xml >>> @@ -7,7 +7,7 @@ >>> (the "License"); you may not use this file except in compliance with >>> the License. You may obtain a copy of the License at >>> >>> - http://www.apache.org/licenses/LICENSE-2.0 >>> + http://www.apache.org/licenses/LICENSE-2.0 >>> >>> Unless required by applicable law or agreed to in writing, software >>> distributed under the License is distributed on an "AS IS" BASIS, >>> > > > > -- > Martin Grigorov > jWeekend > Training, Consulting, Development > http://jWeekend.com
