when using variable placeholders in the log statements there is no
need to check if the logging level is enabled because the call to
check is just as expensive as the call to log.
these kinds of checks only make sense if the log statement uses string
concats like this:
log.warn("page "+page+" cannot be ...")
because then you have the overhead of page's tostring() plus
stringbuilder and concats
-igor
On Wed, Feb 22, 2012 at 8:53 AM, <[email protected]> wrote:
> Check whether warning level is enabled before trying to log.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/2b7b03ac
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/2b7b03ac
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/2b7b03ac
>
> Branch: refs/heads/master
> Commit: 2b7b03acc792dd90e777fa1e7b8d728f74884f34
> Parents: 009884c
> Author: Martin Tzvetanov Grigorov <[email protected]>
> Authored: Wed Feb 22 14:48:45 2012 +0100
> Committer: Martin Tzvetanov Grigorov <[email protected]>
> Committed: Wed Feb 22 14:48:45 2012 +0100
>
> ----------------------------------------------------------------------
> .../apache/wicket/pageStore/DefaultPageStore.java | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/2b7b03ac/wicket-core/src/main/java/org/apache/wicket/pageStore/DefaultPageStore.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-core/src/main/java/org/apache/wicket/pageStore/DefaultPageStore.java
> b/wicket-core/src/main/java/org/apache/wicket/pageStore/DefaultPageStore.java
> index abab7b8..70fc18d 100644
> ---
> a/wicket-core/src/main/java/org/apache/wicket/pageStore/DefaultPageStore.java
> +++
> b/wicket-core/src/main/java/org/apache/wicket/pageStore/DefaultPageStore.java
> @@ -379,7 +379,7 @@ public class DefaultPageStore implements IPageStore
> {
> serializedPage = new SerializedPage(sessionId,
> page.getPageId(), data);
> }
> - else
> + else if (LOG.isWarnEnabled())
> {
> LOG.warn("Page {} cannot be serialized. See previous
> logs for possible reasons.", page);
> }
>
