I just committed my version. On Fri, Apr 20, 2012 at 4:54 PM, Andrea Del Bene <[email protected]> wrote: > Oops! i didn't see your corrected version. > >> On Fri, Apr 20, 2012 at 4:44 PM, Andrea Del Bene<[email protected]> >> wrote: >>> >>> IMHO this version of putAll can be removed...or not :)? >> >> No. Why ? >> #put() does unescape for the value, so #putAll() should do the same. >> >>>> Hi Andrea, >>>> >>>> Strange indeed! >>>> I think it should be : >>>> >>>> @Override >>>> public final void putAll(Map<? extends String, ?> map) >>>> { >>>> for (Map.Entry<? extends String, ?> entry : >>>> map.entrySet()) >>>> { >>>> String key = entry.getKey(); >>>> Object value = entry.getValue(); >>>> put(key, value); >>>> } >>>> } >>>> >>>> >>>> "? extends String" looks strange too >>>> >>>> On Fri, Apr 20, 2012 at 4:31 PM, Andrea Del Bene<[email protected]> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> working on issue 4505 I've noticed that class TagAttributes has the >>>>> following put method: >>>>> >>>>> @Override >>>>> public final void putAll(Map<? extends String, ?> map) >>>>> { >>>>> for (Object o : map.keySet()) >>>>> { >>>>> String key = (String)o; >>>>> } >>>>> >>>>> super.putAll(map); >>>>> } >>>>> >>>>> why this method iterates over map keys and then invoke the super >>>>> version? >>>>> I >>>>> don't understand the purpose of this method. >>>>> >>>> >> >> >
-- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com
