Hi,

Sorry to interfere here. I found a slight problem, which might be related
to WICKET-4506, and results to a some warnings on my side.

org.apache.wicket.markup.html.form.Button#getForm has been overridden,
unfortunately without the generic in the return type, as follow:

    /**
     * Override to not throw exception if there is no parent form.
     *
     * @return the parent form or {@code null}
     */
    @Override
    public Form getForm()
    {
        return Form.findForm(this);
    }

Wheras the return type should be Form<?> (which is - also - the type
returned by Form#findForm).

Thanks,
Sebastien.

On Fri, Apr 27, 2012 at 6:39 PM, Igor Vaynberg <[email protected]>wrote:

> +1
>
> -igor
>
> On Fri, Apr 27, 2012 at 9:28 AM, Martin Grigorov <[email protected]>
> wrote:
> > +1
> >
> > On Fri, Apr 27, 2012 at 7:28 PM, Martin Grigorov <[email protected]>
> wrote:
> >> This vote is to release Apache Wicket 1.5.6
> >>
> >> Git repo
> >> http://git-wip-us.apache.org/repos/asf/wicket.git
> >>
> >> Branch name
> >> build/wicket-1.5.6
> >>
> >> Archived and signed Git repo
> >> http://people.apache.org/~mgrigorov/wicket-1.5.6/
> >>
> >> Changelog
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12319053
> >>
> >> This vote ends Tuesday, May 1th at 19:30 (GMT+2) (One day more because
> >> there are public holidays in few countries in EU)
> >>
> >> Please test the release and offer your vote.
> >>
> >> The Wicket team!
> >>
> >> P.S. Starting with the release of 1.5.6 we wont give binaries for the
> >> vote anymore. You will have to build them locally from the source.
> >> If the vote passes then the binaries will be uploaded to Maven central
> repo.
> >
> >
> >
> > --
> > Martin Grigorov
> > jWeekend
> > Training, Consulting, Development
> > http://jWeekend.com
>

Reply via email to